Source/bindings/core/v8/WorkerScriptController.cpp - Issue 368283002: Stream scripts to V8 as they load - Blink side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 368283002: Stream scripts to V8 as they load - Blink side. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed untrue assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp

index 1a38509dba3e7e7c5e612a1eaf96d50bd7757e50..14c4450373c52cd36e4ba8d9b78b2af6115a541e 100644

--- a/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -214,7 +214,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&

v8::TryCatch block;

v8::Handle<v8::String> scriptString = v8String(m_isolate, script);

- v8::Handle<v8::Script> compiledScript = V8ScriptRunner::compileScript(scriptString, fileName, scriptStartPosition, 0, m_isolate);

+ v8::Handle<v8::Script> compiledScript = V8ScriptRunner::compileScript(scriptString, fileName, scriptStartPosition, 0, 0, m_isolate);

v8::Local<v8::Value> result = V8ScriptRunner::runCompiledScript(compiledScript, &m_workerGlobalScope, m_isolate);

if (!block.CanContinue()) {

« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunnerTest.cpp ('k') | Source/bindings/core/v8/v8.gypi » ('j') | no next file with comments »