Stream scripts to V8 as they load - Blink side.

Source/core/dom/PendingScript.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/PendingScript.h"
 
+#include "bindings/core/v8/V8ScriptStreamer.h"
 #include "core/dom/Element.h"
 #include "core/fetch/ScriptResource.h"
 
 namespace blink {
 
 PendingScript::~PendingScript()
 {
+    if (m_streamer)
+        m_streamer->cancel();

[haraken, 2014/08/17 16:05:28]

Doing something non-trivial in a destructor is likely to cause an issue in
oilpan builds (although there would be no issue in this particular case at this
point).

Can you:

- define PendingScript::dispose() and call m_streamer->cancel() in the
PendingScript::dispose()
- call PendingScript::dispose() from HTMLScriptRunner::detach()

?

[marja, 2014/08/20 11:45:56]

This code turned out to be unnecessary after I refactored watchForLoad and
stopWatchingForLoad (see a later comment about refactoring them). So now
HTMLScriptRunner simply calls stopWatchingForLoad and that will call cancel().

 }
 
 PassRefPtrWillBeRawPtr<Element> PendingScript::releaseElementAndClear()
 {
     setScriptResource(0);
     m_watchingForLoad = false;
     m_startingPosition = TextPosition::belowRangePosition();
     return m_element.release();
 }
 
 void PendingScript::setScriptResource(ScriptResource* resource)
 {
+    ASSERT(!m_streamer);
     setResource(resource);
 }
 
 void PendingScript::notifyFinished(Resource*)
 {
+    if (m_streamer) {
+        m_streamer->notifyFinished();
+    }
+}
+
+void PendingScript::notifyAppendData(ScriptResource*)
+{
+    if (m_streamer) {
+        m_streamer->notifyAppendData();
+    }
 }
 
 void PendingScript::trace(Visitor* visitor)
 {
     visitor->trace(m_element);
 }
 
+bool PendingScript::isStreaming() const
+{
+    return m_streamer && m_streamer->streamingInProgress();
 }
+
+}