Stream scripts to V8 as they load - Blink side.

Source/core/Init.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "Init.h"
 
+#include "bindings/core/v8/V8ScriptStreamerThread.h"
 #include "core/EventNames.h"
 #include "core/EventTargetNames.h"
 #include "core/EventTypeNames.h"
 #include "core/FetchInitiatorTypeNames.h"
 #include "core/HTMLNames.h"
 #include "core/HTMLTokenizerNames.h"
 #include "core/InputTypeNames.h"
 #include "core/MathMLNames.h"
 #include "core/MediaFeatureNames.h"
 #include "core/MediaTypeNames.h"
@@ skipping 66 matching lines @@
 
     initBindings();
     registerEventFactory();
 
     // Ensure that the main thread's thread-local data is initialized before
     // starting any worker threads.
     PlatformThreadData::current();
 
     StringImpl::freezeStaticStrings();
 
-    // Creates HTMLParserThread::shared, but does not start the thread.
+    // Creates HTMLParserThread::shared and V8ScriptStreamerThread::shared, but
+    // does not start the threads.
     HTMLParserThread::init();
+    V8ScriptStreamerThread::init();
 }
 
 void CoreInitializer::shutdown()
 {
-    // Make sure we stop the HTMLParserThread before Platform::current() is cleared.
+    // Make sure we stop the HTMLParserThread and V8ScriptStreamerThread before
+    // Platform::current() is cleared.
     HTMLParserThread::shutdown();
+    V8ScriptStreamerThread::shutdown();

[haraken, 2014/08/17 16:05:28]

We want to shutdown threads in the reverse order of init() calls. So let's call
V8ScriptStreamerThread::shutdown() and then HTMLParserThread::shutdown().

[marja, 2014/08/20 11:45:56]

Done. I guess it'd only make a difference if the threads post tasks to each
other, and even then, that can only go one way... it's not like both can post
tasks to each other. Or is there some more realistic use case where it would
matter?

(I was also wondering if we need to shut down the thread before destroying the
Isolate in shutdown() in WebKit.cpp, but I guess not, since the background
parser thread doesn't access the isolate.)

[haraken, 2014/08/20 15:00:19]

I don't know any specific cases where the order matters, but the current
shutdown logic is carefully written in the exactly reverse order of init()
calls. So let's just follow the rule here.

 
     Partitions::shutdown();
 }
 
 } // namespace blink