Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 368273008: [WebView] Fix issue with transparent background. (Closed)

Created:
6 years, 5 months ago by Ignacio Solla
Modified:
6 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[WebView] Fix issue with transparent background. Always make the background of the layer tree host in the parent compositor transparent to avoid covering up the background color of the WebView. BUG=391462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M android_webview/browser/browser_view_renderer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +0 lines, -6 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ignacio Solla
6 years, 5 months ago (2014-07-04 10:02:06 UTC) #1
boliu
lgtm This is the right thing to do. I wasn't thinking clearly when I told ...
6 years, 5 months ago (2014-07-04 14:32:23 UTC) #2
Ignacio Solla
On 2014/07/04 14:32:23, boliu wrote: > lgtm > > This is the right thing to ...
6 years, 5 months ago (2014-07-04 14:40:04 UTC) #3
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 5 months ago (2014-07-04 14:40:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/368273008/1
6 years, 5 months ago (2014-07-04 14:40:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 18:34:28 UTC) #6
Message was sent while issue was closed.
Change committed as 281427

Powered by Google App Engine
This is Rietveld 408576698