Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: src/lithium-codegen.cc

Issue 368263003: Use a stub in crankshaft for grow store arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Performance fixes. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ia32/lithium-ia32.cc ('K') | « src/isolate.cc ('k') | src/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lithium-codegen.cc
diff --git a/src/lithium-codegen.cc b/src/lithium-codegen.cc
index 1e7178551508f8c0afae7d0849fd55239ce14590..510a582c7fe7b4b226a778ce5ab2fa988249326b 100644
--- a/src/lithium-codegen.cc
+++ b/src/lithium-codegen.cc
@@ -112,7 +112,11 @@ void LCodeGenBase::CheckEnvironmentUsage() {
if (dead_block || !hval->block()->IsReachable()) continue;
HInstruction* hinstr = HInstruction::cast(hval);
- if (!hinstr->CanDeoptimize() && instr->HasEnvironment()) {
+ // TODO(mvstanton): Verify that the side effects exemption is correct and
+ // sufficient.
+ if (!hinstr->CanDeoptimize() && instr->HasEnvironment() &&
+ !(hinstr->IsCallWithDescriptor() &&
+ !hinstr->HasObservableSideEffects())) {
V8_Fatal(__FILE__, __LINE__, "CanDeoptimize is wrong for %s (%s)\n",
hinstr->Mnemonic(), instr->Mnemonic());
}
« src/ia32/lithium-ia32.cc ('K') | « src/isolate.cc ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698