Use a stub in crankshaft for grow store arrays.

src/ia32/lithium-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_IA32
 
 #include "src/hydrogen-osr.h"
 #include "src/ia32/lithium-codegen-ia32.h"
@@ skipping 1106 matching lines @@
   LOperand* function = UseFixed(instr->function(), edi);
 
   LCallJSFunction* result = new(zone()) LCallJSFunction(function);
 
   return MarkAsCall(DefineFixed(result, eax), instr, CANNOT_DEOPTIMIZE_EAGERLY);
 }
 
 
 LInstruction* LChunkBuilder::DoCallWithDescriptor(
     HCallWithDescriptor* instr) {
-  const CallInterfaceDescriptor* descriptor = instr->descriptor();
-
+  bool is_stub = instr->is_stub();
+  ZoneList<LOperand*> ops(instr->OperandCount(), zone());
   LOperand* target = UseRegisterOrConstantAtStart(instr->target());
-  ZoneList<LOperand*> ops(instr->OperandCount(), zone());
   ops.Add(target, zone());
-  for (int i = 1; i < instr->OperandCount(); i++) {
-    LOperand* op = UseFixed(instr->OperandAt(i),
-        descriptor->GetParameterRegister(i - 1));
+  if (is_stub) {
+    LOperand* context = UseFixed(instr->context(), esi);
+    ops.Add(context, zone());
+  }
+  int start_index = is_stub ? 2 : 1;
+  for (int i = start_index; i < instr->OperandCount(); i++) {
+    Register reg = instr->is_stub()
+        ? instr->stub_descriptor()->GetParameterRegister(i - start_index)
+        : instr->call_descriptor()->GetParameterRegister(i - start_index);
+    LOperand* op = UseFixed(instr->OperandAt(i), reg);
     ops.Add(op, zone());
   }
 
   LCallWithDescriptor* result = new(zone()) LCallWithDescriptor(
-      descriptor, ops, zone());
+      ops, zone());

[danno, 2014/07/11 12:30:30]

clang format the patch?

[mvstanton, 2014/07/21 09:41:17]

This whole block is gone, I no longer need to change DoCallWithDescriptor().

   return MarkAsCall(DefineFixed(result, eax), instr, CANNOT_DEOPTIMIZE_EAGERLY);
 }
 
 
 LInstruction* LChunkBuilder::DoInvokeFunction(HInvokeFunction* instr) {
   LOperand* context = UseFixed(instr->context(), esi);
   LOperand* function = UseFixed(instr->function(), edi);
   LInvokeFunction* result = new(zone()) LInvokeFunction(context, function);
   return MarkAsCall(DefineFixed(result, eax), instr, CANNOT_DEOPTIMIZE_EAGERLY);
 }
@@ skipping 1517 matching lines @@
   LOperand* function = UseRegisterAtStart(instr->function());
   LAllocateBlockContext* result =
       new(zone()) LAllocateBlockContext(context, function);
   return MarkAsCall(DefineFixed(result, esi), instr);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32