Use a stub in crankshaft for grow store arrays.

src/hydrogen-instructions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
 #define V8_HYDROGEN_INSTRUCTIONS_H_
 
 #include "src/v8.h"
 
 #include "src/allocation.h"
@@ skipping 2289 matching lines @@
       int argument_count,
       const CallInterfaceDescriptor* descriptor,
       const Vector<HValue*>& operands) {
     ASSERT(operands.length() == descriptor->environment_length());
     HCallWithDescriptor* res =
         new(zone) HCallWithDescriptor(target, argument_count,
                                       descriptor, operands, zone);
     return res;
   }
 
+  static HCallWithDescriptor* New(Zone* zone, HValue* context,
+      HValue* target,
+      int argument_count,
+      const CodeStubInterfaceDescriptor* descriptor,
+      const Vector<HValue*>& operands) {
+    ASSERT(operands.length() == descriptor->environment_length());
+    HCallWithDescriptor* res =
+        new(zone) HCallWithDescriptor(target, argument_count,
+                                      descriptor, operands, context,
+                                      zone);
+    return res;
+  }
+
   virtual int OperandCount() V8_FINAL V8_OVERRIDE { return values_.length(); }
   virtual HValue* OperandAt(int index) const V8_FINAL V8_OVERRIDE {
     return values_[index];
   }
 
   virtual Representation RequiredInputRepresentation(
       int index) V8_FINAL V8_OVERRIDE {
+    if (is_stub_) {
+      if (index < 2) {

[danno, 2014/07/11 12:30:30]

I think a little more comments/constants are needed here... what are the first
two parameters, and why are they always tagged... context and JSFunction?

[mvstanton, 2014/07/21 09:41:17]

Happily, we've now repaired this whole area so this CL no longer touches
HCallWithDescriptor.

+        return Representation::Tagged();
+      } else {
+        int par_index = index - 2;
+        ASSERT(par_index < stub_descriptor_->environment_length());
+        return stub_descriptor_->GetParameterRepresentation(par_index);
+      }
+    }
+
+    ASSERT(!is_stub_);
     if (index == 0) {
       return Representation::Tagged();
     } else {
       int par_index = index - 1;
-      ASSERT(par_index < descriptor_->environment_length());
-      return descriptor_->GetParameterRepresentation(par_index);
+      ASSERT(par_index < call_descriptor_->environment_length());
+      return call_descriptor_->GetParameterRepresentation(par_index);
     }
   }
 
   DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor)
 
   virtual HType CalculateInferredType() V8_FINAL V8_OVERRIDE {
     return HType::Tagged();
   }
 
   virtual int argument_count() const {
     return argument_count_;
   }
 
   virtual int argument_delta() const V8_OVERRIDE {
     return -argument_count_;
   }
 
-  const CallInterfaceDescriptor* descriptor() const {
-    return descriptor_;
+  bool is_stub() const { return is_stub_; }
+
+  const CallInterfaceDescriptor* call_descriptor() const {
+    ASSERT(!is_stub_);
+    return call_descriptor_;
+  }
+
+  const CodeStubInterfaceDescriptor* stub_descriptor() const {
+    ASSERT(is_stub_);
+    return stub_descriptor_;
   }
 
   HValue* target() {
     return OperandAt(0);
   }
 
+  HValue* context() {
+    ASSERT(is_stub_);
+    return OperandAt(1);
+  }
+
   virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
 
  private:
   // The argument count includes the receiver.
   HCallWithDescriptor(HValue* target,
                       int argument_count,
                       const CallInterfaceDescriptor* descriptor,
                       const Vector<HValue*>& operands,
                       Zone* zone)
-    : descriptor_(descriptor),
+    : is_stub_(false),
+      call_descriptor_(descriptor),
       values_(descriptor->environment_length() + 1, zone) {
     argument_count_ = argument_count;
     AddOperand(target, zone);
     for (int i = 0; i < operands.length(); i++) {
       AddOperand(operands[i], zone);
     }
     this->set_representation(Representation::Tagged());
     this->SetAllSideEffects();
   }
 
+  // The argument count includes the receiver.
+  HCallWithDescriptor(HValue* target,
+                      int argument_count,
+                      const CodeStubInterfaceDescriptor* descriptor,
+                      const Vector<HValue*>& operands,
+                      HValue* context,
+                      Zone* zone)
+    : is_stub_(true),
+      stub_descriptor_(descriptor),
+      values_(descriptor->environment_length() + 2, zone) {
+    argument_count_ = argument_count;
+    AddOperand(target, zone);
+    AddOperand(context, zone);
+    for (int i = 0; i < operands.length(); i++) {
+      AddOperand(operands[i], zone);
+    }
+    this->set_representation(Representation::Tagged());
+    this->SetAllSideEffects();
+  }
+
   void AddOperand(HValue* v, Zone* zone) {
     values_.Add(NULL, zone);
     SetOperandAt(values_.length() - 1, v);
   }
 
   void InternalSetOperandAt(int index,
                             HValue* value) V8_FINAL V8_OVERRIDE {
     values_[index] = value;
   }
 
-  const CallInterfaceDescriptor* descriptor_;
+  const bool is_stub_;
+  union {
+    const CodeStubInterfaceDescriptor* stub_descriptor_;
+    const CallInterfaceDescriptor* call_descriptor_;
+  };
   ZoneList<HValue*> values_;
   int argument_count_;
 };
 
 
 class HInvokeFunction V8_FINAL : public HBinaryCall {
  public:
   DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P2(HInvokeFunction, HValue*, int);
 
   HInvokeFunction(HValue* context,
@@ skipping 5398 matching lines @@
 };
 
 
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_