Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
368253002:
Do not export SkTDArray when building Skia as a DLL (Closed)
DescriptionDo not export SkTDArray when building Skia as a DLL
This class has four members (deleteAll, freeAll, unrefAll and
safeUnrefAll) which will only compile for certain instantiations of
SkTDArray depending on the template argument type. Marking this class
as dllexport breaks the build with clang-cl because of
http://llvm.org/PR20163. Since this class is header-only, we can just
make it non-exported to enable building Skia as a DLL with clang-cl.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/db5f7bf0a439b744facda6b6b1590b4554d64fd8
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 20 (0 generated)
We need this patch in order to be able to build Skia with clang-cl for Firefox. Setting Chris as the reviewer because he originally added SKAPI to this class.
testing canaries (esp. sharedlib)
On 2014/07/07 13:21:52, reed1 wrote: > testing canaries (esp. sharedlib) Looks like Chrome is broken at head. That said, this LGTM. I'm with rnk on this one: SK_API doesn't make any sense on a template class. We probably just added mechanically along with everything else in include/?
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/ehsan.akhgari@gmail.com/368253002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 368253002-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** The email ehsan.akhgari@gmail.com is not in Skia's AUTHORS file. Issue owner, this CL must include an addition to the Skia AUTHORS file. Googler reviewers, please check that the AUTHORS entry corresponds to an email address in http://goto/cla-signers. If it does not then ask the issue owner to sign the CLA at https://developers.google.com/open-source/cla/individual (individual) or https://developers.google.com/open-source/cla/corporate (corporate). Was the presubmit check useful? If not, run "git cl presubmit -v" to figure out which PRESUBMIT.py was run, then run git blame on the file to figure out who to ask for help.
On 2014/07/07 14:04:27, I haz the power (commit-bot) wrote: > Presubmit check for 368253002-1 failed and returned exit status 1. > > Running presubmit commit checks ... > > ** Presubmit ERRORS ** > The email mailto:ehsan.akhgari@gmail.com is not in Skia's AUTHORS file. > Issue owner, this CL must include an addition to the Skia AUTHORS file. > Googler reviewers, please check that the AUTHORS entry corresponds to an email > address in http://goto/cla-signers. If it does not then ask the issue owner to > sign the CLA at https://developers.google.com/open-source/cla/individual > (individual) or https://developers.google.com/open-source/cla/corporate > (corporate). > > Was the presubmit check useful? If not, run "git cl presubmit -v" > to figure out which PRESUBMIT.py was run, then run git blame > on the file to figure out who to ask for help. Oh, should I add my name to that file and resubmit?
On 2014/07/07 14:25:38, ehsan wrote: > On 2014/07/07 14:04:27, I haz the power (commit-bot) wrote: > > Presubmit check for 368253002-1 failed and returned exit status 1. > > > > Running presubmit commit checks ... > > > > ** Presubmit ERRORS ** > > The email mailto:ehsan.akhgari@gmail.com is not in Skia's AUTHORS file. > > Issue owner, this CL must include an addition to the Skia AUTHORS file. > > Googler reviewers, please check that the AUTHORS entry corresponds to an email > > address in http://goto/cla-signers. If it does not then ask the issue owner to > > sign the CLA at https://developers.google.com/open-source/cla/individual > > (individual) or https://developers.google.com/open-source/cla/corporate > > (corporate). > > > > Was the presubmit check useful? If not, run "git cl presubmit -v" > > to figure out which PRESUBMIT.py was run, then run git blame > > on the file to figure out who to ask for help. > > Oh, should I add my name to that file and resubmit? I tried doing that now but when I try to repush, I get: $ git push origin clang-cl:refs/for/master fatal: remote error: Git access forbidden This is the AUTHORS diff, I'd appreciate if someone could please resubmit this: diff --git a/AUTHORS b/AUTHORS index 96f53ce..8dd39a6 100644 --- a/AUTHORS +++ b/AUTHORS @@ -19,6 +19,7 @@ Igalia <*@igalia.com> Intel <*@intel.com> Jacek Caban <cjacek@gmail.com> MIPS <*@imgtec.com> +Mozilla Foundation <ehsan.akhgari@gmail.com> NVIDIA <*@nvidia.com> Opera Software ASA <*@opera.com> Samsung <*@samsung.com> Thanks!
On 2014/07/08 12:39:59, ehsan wrote: > On 2014/07/07 14:25:38, ehsan wrote: > > On 2014/07/07 14:04:27, I haz the power (commit-bot) wrote: > > > Presubmit check for 368253002-1 failed and returned exit status 1. > > > > > > Running presubmit commit checks ... > > > > > > ** Presubmit ERRORS ** > > > The email mailto:ehsan.akhgari@gmail.com is not in Skia's AUTHORS file. > > > Issue owner, this CL must include an addition to the Skia AUTHORS file. > > > Googler reviewers, please check that the AUTHORS entry corresponds to an > email > > > address in http://goto/cla-signers. If it does not then ask the issue owner > to > > > sign the CLA at https://developers.google.com/open-source/cla/individual > > > (individual) or https://developers.google.com/open-source/cla/corporate > > > (corporate). > > > > > > Was the presubmit check useful? If not, run "git cl presubmit -v" > > > to figure out which PRESUBMIT.py was run, then run git blame > > > on the file to figure out who to ask for help. > > > > Oh, should I add my name to that file and resubmit? > > I tried doing that now but when I try to repush, I get: > > $ git push origin clang-cl:refs/for/master > fatal: remote error: Git access forbidden > > This is the AUTHORS diff, I'd appreciate if someone could please resubmit this: > > diff --git a/AUTHORS b/AUTHORS > index 96f53ce..8dd39a6 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -19,6 +19,7 @@ Igalia <mailto:*@igalia.com> > Intel <mailto:*@intel.com> > Jacek Caban <mailto:cjacek@gmail.com> > MIPS <mailto:*@imgtec.com> > +Mozilla Foundation <mailto:ehsan.akhgari@gmail.com> > NVIDIA <mailto:*@nvidia.com> > Opera Software ASA <mailto:*@opera.com> > Samsung <mailto:*@samsung.com> > > Thanks! NM, I remembered that I needed to use git cl! :-) The patch is updated now.
The CQ bit was checked by ehsan.akhgari@gmail.com
The CQ bit was unchecked by ehsan.akhgari@gmail.com
On 2014/07/08 12:43:07, ehsan wrote: > The CQ bit was unchecked by mailto:ehsan.akhgari@gmail.com Looks to me like you're already covered under Mozilla for the CLA: https://docs.google.com/a/google.com/spreadsheets/d/1N4NW6EMv-j_VEZaX_clH4Hjj... So, I'd think we just add Ehsan Akhgari <ehsan.akhgari@gmail.com> ?
On 2014/07/08 13:03:40, mtklein wrote: > On 2014/07/08 12:43:07, ehsan wrote: > > The CQ bit was unchecked by mailto:ehsan.akhgari@gmail.com > > Looks to me like you're already covered under Mozilla for the CLA: > https://docs.google.com/a/google.com/spreadsheets/d/1N4NW6EMv-j_VEZaX_clH4Hjj... > > So, I'd think we just add > > Ehsan Akhgari <mailto:ehsan.akhgari@gmail.com> > > ? I don't have access to that document, but the copyright of my work is owned by Mozilla, so that's fine by me!
On 2014/07/08 13:11:15, ehsan wrote: > On 2014/07/08 13:03:40, mtklein wrote: > > On 2014/07/08 12:43:07, ehsan wrote: > > > The CQ bit was unchecked by mailto:ehsan.akhgari@gmail.com > > > > Looks to me like you're already covered under Mozilla for the CLA: > > > https://docs.google.com/a/google.com/spreadsheets/d/1N4NW6EMv-j_VEZaX_clH4Hjj... > > > > So, I'd think we just add > > > > Ehsan Akhgari <mailto:ehsan.akhgari@gmail.com> > > > > ? > > I don't have access to that document, but the copyright of my work is owned by > Mozilla, so that's fine by me! ping? Anything else I need to do here?
Let's try!
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/ehsan.akhgari@gmail.com/368253002/40001
Message was sent while issue was closed.
Change committed as db5f7bf0a439b744facda6b6b1590b4554d64fd8 |
