Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 368233004: ONC: Cleanup client certificate related fields. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ONC: Cleanup client certificate related fields. Before, each network type had its own constants for ClientCert{Type,Pattern,Ref} which lead to duplicate implementations. These constants are now unified into the namespace onc::client_cert together with the other client certificate related constants. This leads to a clearer separation from the Certificate ONC object (has namespace onc::certificate) and simplifies some code (see network_ui_data.cc and onc_validator.cc). BUG=391292 (For trivial constant renaming:) TBR=mef@chromium.org,vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281820

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebased. #

Patch Set 3 : Addressed comments. #

Patch Set 4 : Fix compilation on Win/Mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -185 lines) Patch
M chrome/browser/chromeos/net/onc_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/wifi/wifi_manager_nonchromeos.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/certificate_pattern.cc View 1 4 chunks +16 lines, -16 lines 0 comments Download
M chromeos/network/network_ui_data.cc View 1 2 2 chunks +17 lines, -38 lines 0 comments Download
M chromeos/network/onc/onc_normalizer.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_validator.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 2 14 chunks +45 lines, -53 lines 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/onc/onc_constants.h View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M components/onc/onc_constants.cc View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M components/wifi/network_properties.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_service_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_service_win.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pneubeck (no reviews)
pure refactoring, mostly name substitution.
6 years, 5 months ago (2014-07-03 15:20:15 UTC) #1
stevenjb
lgtm with nits https://codereview.chromium.org/368233004/diff/80001/chromeos/network/onc/onc_validator.h File chromeos/network/onc/onc_validator.h (right): https://codereview.chromium.org/368233004/diff/80001/chromeos/network/onc/onc_validator.h#newcode153 chromeos/network/onc/onc_validator.h:153: bool allow_cert_type_none); 'result' should be last ...
6 years, 5 months ago (2014-07-07 19:19:15 UTC) #2
pneubeck (no reviews)
https://codereview.chromium.org/368233004/diff/80001/chromeos/network/onc/onc_validator.h File chromeos/network/onc/onc_validator.h (right): https://codereview.chromium.org/368233004/diff/80001/chromeos/network/onc/onc_validator.h#newcode153 chromeos/network/onc/onc_validator.h:153: bool allow_cert_type_none); On 2014/07/07 19:19:14, stevenjb wrote: > 'result' ...
6 years, 5 months ago (2014-07-08 09:14:37 UTC) #3
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-08 13:51:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/368233004/120001
6 years, 5 months ago (2014-07-08 13:52:34 UTC) #5
pneubeck (no reviews)
6 years, 5 months ago (2014-07-08 14:19:08 UTC) #6
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-08 14:19:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/368233004/140001
6 years, 5 months ago (2014-07-08 14:21:29 UTC) #8
mef
c/wifi/* lgtm
6 years, 5 months ago (2014-07-08 14:25:47 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 16:29:12 UTC) #10
commit-bot: I haz the power
Change committed as 281820
6 years, 5 months ago (2014-07-08 20:58:20 UTC) #11
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-09 00:35:55 UTC) #12
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698