Issue 36823002: Remove deprecated method Notification::detachPresenter()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36823002: Remove deprecated method Notification::detachPresenter() (Closed)

Created:
7 years, 2 months ago by tyoshino (SeeGerritForStatus)

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove deprecated method Notification::detachPresenter() In Chromium, the only implementation of WebNotificationPresenter, content::NotificationProvider never goes away. Rather than implementing it or leaving it empty, just remove it. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161539

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
M	Source/modules/notifications/Notification.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/web/WebNotification.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebNotification.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

Chromium side change https://codereview.chromium.org/36073007/

7 years, 1 month ago (2013-10-31 09:31:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/36823002/50001

7 years, 1 month ago (2013-11-07 13:55:15 UTC) #3

Message was sent while issue was closed.

Change committed as 161539

Expand Messages | Collapse Messages