Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 368203002: Block mixed <picture> and <img srcset> by default. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Block mixed <picture> and <img srcset> by default. It's going to be more or less impossible to begin blocking mixed <img> content by default, given the amount of usage we're likely to see in the wild (I'm still waiting for metrics from Chrome stable, but I'm not hopeful). I think it will be significantly less impossible to avoid the same mistake with the new responsive hotness. This CL treats <picture> and <img srcset> as active content, blocking them by default when mixed. ------------------------------------------------------------------------ This is a re-land of r177385, which was reverted because it broke a few browser_tests, Chromium-side. This patch differs from the initial patch[1] only in that it now starts with a copy of 'ResourceFetcher::defaultResourceLoaderOptions()' rather than an empty ResourceLoaderOptions. [1]: https://codereview.chromium.org/356243003 ------------------------------------------------------------------------ BUG=390158 TBR=yoav@yoav.ws Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177464

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
Mike West
TBRing you, Yoav. Relanding this CL after fixing the ResourceLoaderOptions that caused the revert yesterday. ...
6 years, 5 months ago (2014-07-03 09:32:22 UTC) #1
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-03 09:32:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/368203002/1
6 years, 5 months ago (2014-07-03 09:33:17 UTC) #3
commit-bot: I haz the power
Change committed as 177464
6 years, 5 months ago (2014-07-03 10:40:39 UTC) #4
Yoav Weiss
6 years, 5 months ago (2014-07-03 10:58:10 UTC) #5
Message was sent while issue was closed.
On 2014/07/03 10:40:39, I haz the power (commit-bot) wrote:
> Change committed as 177464

Retroactive 
LGTM :)

Powered by Google App Engine
This is Rietveld 408576698