Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 368163004: Reenable most panel interactive_ui_tests on Linux (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Dmitry Titov, jianli
CC:
chromium-reviews, tfarina, jennb, jianli, dcheng
Project:
chromium
Visibility:
Public.

Description

Reenable most panel interactive_ui_tests on Linux BUG=382301 TEST=Panel interactive_ui_tests pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283752

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
M chrome/browser/ui/panels/detached_panel_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 2 chunks +0 lines, -9 lines 1 comment Download
M chrome/browser/ui/views/panels/panel_view.cc View 7 chunks +24 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view_browsertest.cc View 2 chunks +4 lines, -0 lines 1 comment Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
jianli@ PTAL https://codereview.chromium.org/368163004/diff/20001/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (left): https://codereview.chromium.org/368163004/diff/20001/chrome/browser/ui/panels/panel_browsertest.cc#oldcode525 chrome/browser/ui/panels/panel_browsertest.cc:525: #if !defined(OS_LINUX) It will take some time ...
6 years, 5 months ago (2014-07-07 14:55:47 UTC) #1
pkotwicz
jianli@ seems to be OOO. dimich@ PTAL
6 years, 5 months ago (2014-07-14 17:56:12 UTC) #2
Dmitry Titov
LGTM Awesome, thanks a lot!
6 years, 5 months ago (2014-07-16 17:48:44 UTC) #3
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-16 19:04:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/368163004/20001
6 years, 5 months ago (2014-07-16 19:06:49 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:16:38 UTC) #6
Message was sent while issue was closed.
Change committed as 283752

Powered by Google App Engine
This is Rietveld 408576698