Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3452)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 368143002: Add a chrome://interstitials page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: felt comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index ca97c2b60a0a90009235bd3716fc0b3b657f2126..ce532a5023f8cf94f29f236a5ad594956e1da094 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -222,6 +222,7 @@ void RecordSSLBlockingPageDetailedStats(
// No error happening loading a sub-resource triggers an interstitial so far.
SSLBlockingPage::SSLBlockingPage(
content::WebContents* web_contents,
+ bool create_interstitial,
int cert_error,
const net::SSLInfo& ssl_info,
const GURL& request_url,
@@ -278,9 +279,15 @@ SSLBlockingPage::SSLBlockingPage(
content::Source<Profile>(profile));
#endif
- interstitial_page_ = InterstitialPage::Create(
- web_contents_, true, request_url, this);
- interstitial_page_->Show();
+ // chrome://interstitials page uses this class without actually creating an
+ // interstitial so that it can be debugged. Set |create_interstitial| to true
+ // if the page is going to be used as an actual interstitial and not just part
+ // of the chrome://interstitials webui.
+ if (create_interstitial) {
+ interstitial_page_ = InterstitialPage::Create(
+ web_contents_, true, request_url, this);
+ interstitial_page_->Show();
+ }
}
SSLBlockingPage::~SSLBlockingPage() {

Powered by Google App Engine
This is Rietveld 408576698