Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3349)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 368143002: Add a chrome://interstitials page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Too many constructors Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index d0d95b8f5e744a3b3f0981549be09553bfe39b42..2d594d8c8872d182cb5522b8c828b3d3f8f19404 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -260,6 +260,7 @@ bool IsErrorProbablyCausedByClock(bool overridable, int cert_info) {
// No error happening loading a sub-resource triggers an interstitial so far.
SSLBlockingPage::SSLBlockingPage(
content::WebContents* web_contents,
+ bool create_interstitial,
int cert_error,
const net::SSLInfo& ssl_info,
const GURL& request_url,
@@ -311,9 +312,11 @@ SSLBlockingPage::SSLBlockingPage(
content::Source<Profile>(profile));
#endif
- interstitial_page_ = InterstitialPage::Create(
- web_contents_, true, request_url, this);
- interstitial_page_->Show();
+ if (create_interstitial) {
felt 2014/07/15 01:35:07 can you add a comment here explaining what this is
meacer 2014/07/15 19:48:06 Done.
+ interstitial_page_ = InterstitialPage::Create(
+ web_contents_, true, request_url, this);
+ interstitial_page_->Show();
+ }
}
SSLBlockingPage::~SSLBlockingPage() {

Powered by Google App Engine
This is Rietveld 408576698