Add a chrome://interstitials page.

Add a chrome://interstitials page.

Screenshots:
https://docs.google.com/file/d/0B9q2eN9gDoUIUUhrMlpydVNTVXc/edit?pli=1
https://drive.google.com/file/d/0B9q2eN9gDoUIMjdhQ1p3M05zNDQ/edit?usp=sharing

BUG=389749
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285766

[meacer, 2014-07-14 19:43:25]

felt, pfeldman: What do you think about this?

[pfeldman, 2014-07-14 20:49:19]

This is no longer about devtools code-wise, so deferring it to felt@ and the
owners.

[felt, 2014-07-15 01:35:07]

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:315: if (create_interstitial) {
This makes me a little nervous -- can you add a comment here to make sure
someone else doesn't come along and screw up the conditional?

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/interstitials/interstitial_ui.cc (right):

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:56:
SafeBrowsingBlockingPage* CreateSafebrowsingBlockingPage(
nit: usually spelled as SafeBrowsing (capital 'B')

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:146: "<a
href='ssl?url=https://google.com'>SSL (google.com)</a><br>"
ahh the passing parameters is pretty slick

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:315: if (create_interstitial) {
can you add a comment here explaining what this is for

[felt, 2014-07-15 01:38:26]

I'm pretty happy about this :D

My one regret is that it requires adding another parameter to the
SSLBlockingPage and SafeBrowsingBlockingPage constructors, just for the sake of
testing. But I am not sure if there is a better way, since that setup does need
to be done in the constructor.

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.h (right):

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:27: public:
^ nit: indent one?

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:43: private:
^ nit: indent one?

[meacer, 2014-07-15 19:48:07]

> My one regret is that it requires adding another parameter to the
> SSLBlockingPage and SafeBrowsingBlockingPage constructors, just for the sake
of
> testing. But I am not sure if there is a better way, since that setup does
need
> to be done in the constructor.

Agreed. Other options are to subclass them for webui or add static methods such
as Create() and CreateForWebUI() but they seemed overkill to me.

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:315: if (create_interstitial) {
On 2014/07/15 01:35:07, felt wrote:
> This makes me a little nervous -- can you add a comment here to make sure
> someone else doesn't come along and screw up the conditional?

Done.

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/interstitials/interstitial_ui.cc (right):

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:56:
SafeBrowsingBlockingPage* CreateSafebrowsingBlockingPage(
On 2014/07/15 01:35:07, felt wrote:
> nit: usually spelled as SafeBrowsing (capital 'B')

Done.

https://codereview.chromium.org/368143002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:146: "<a
href='ssl?url=https://google.com'>SSL (google.com)</a><br>"
On 2014/07/15 01:35:07, felt wrote:
> ahh the passing parameters is pretty slick

Looking forward to bug reports where people use weird combinations and crash
Chrome.

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:315: if (create_interstitial) {
On 2014/07/15 01:35:07, felt wrote:
> can you add a comment here explaining what this is for

Done.

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.h (right):

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:27: public:
On 2014/07/15 01:38:26, felt wrote:
> ^ nit: indent one?

Done.

https://codereview.chromium.org/368143002/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:43: private:
On 2014/07/15 01:38:26, felt wrote:
> ^ nit: indent one?

Actually the next two lines had unnecessary indent. Removed those.

[meacer, 2014-07-15 19:54:17]

-pfeldman

OWNERs, can you please take a look at the respective files?

+palmer for ssl_blocking_page.*
+bryner for safe_browsing_blocking_page.*
+bauerb for chrome/browser/ui/webui/interstitials/*

[palmer, 2014-07-15 20:48:40]

lgtm

[Bernhard Bauer, 2014-07-16 10:22:46]

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2008: new SSLBlockingPage(tab,
true, cert_error, ssl_info, request_url, overridable,
Would it make sense to make this a method ShowSSLBlockingPage, analog to
SafeBrowsing?

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.cc (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:34: for
(net::QueryIterator it(web_contents->GetURL());
Wouldn't it be a little easier to just use net::GetValueForKeyInQuery()?

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:53: callback);
Pass in an empty callback here directly?

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.h (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:26: class
InterstitialHTMLSource : public content::URLDataSource {
Do we need this in the header, or could we move it to the anonymous namespace in
the .cc file?

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
(right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc:21:
content::WebContents* GetInspectedTab() {
Is this used?

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc:25: void
TestInterstitial(GURL url, std::string page_title) {
const std::string&

[Brian Ryner, 2014-07-16 17:39:10]

Noe could you please review for safe_browsing_blocking_page?

[meacer, 2014-07-16 21:21:40]

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:2008: new SSLBlockingPage(tab,
true, cert_error, ssl_info, request_url, overridable,
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> Would it make sense to make this a method ShowSSLBlockingPage, analog to
> SafeBrowsing?

Added Show and CreateForWebUI static methods to SSLBlockingPage.

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.cc (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:34: for
(net::QueryIterator it(web_contents->GetURL());
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> Wouldn't it be a little easier to just use net::GetValueForKeyInQuery()?

It's actually longer now, but I think it's more readable.

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:53: callback);
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> Pass in an empty callback here directly?

Done.

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.h (right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.h:26: class
InterstitialHTMLSource : public content::URLDataSource {
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> Do we need this in the header, or could we move it to the anonymous namespace
in
> the .cc file?

Good call, moved into the cc file.

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
(right):

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc:21:
content::WebContents* GetInspectedTab() {
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> Is this used?

Done.

https://codereview.chromium.org/368143002/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc:25: void
TestInterstitial(GURL url, std::string page_title) {
On 2014/07/16 10:22:45, Bernhard Bauer wrote:
> const std::string&

Done.

[Bernhard Bauer, 2014-07-16 21:49:59]

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:320: true,
What I meant was that you could show it from here, then you don't need that
parameter?

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:337: // The callee owns the blocking
page.
This comment would be better off in the header. But could you just make this
return a scoped_ptr? Then it would be implied anyway.

[meacer, 2014-07-17 21:24:09]

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:320: true,
On 2014/07/16 21:49:59, Bernhard Bauer wrote:
> What I meant was that you could show it from here, then you don't need that
> parameter?

Done.

https://codereview.chromium.org/368143002/diff/140001/chrome/browser/ssl/ssl_...
chrome/browser/ssl/ssl_blocking_page.cc:337: // The callee owns the blocking
page.
On 2014/07/16 21:49:59, Bernhard Bauer wrote:
> This comment would be better off in the header. But could you just make this
> return a scoped_ptr? Then it would be implied anyway.

Returning scoped_ptr makes the code slightly more complicated (for consistency
SafeBrowsingBlockingPage::CreateBlockingPage would return a scoped_ptr as well
and that introduces more code changes). So I'll keep it as a raw pointer.

https://codereview.chromium.org/368143002/diff/160001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/interstitials/interstitial_ui.cc (right):

https://codereview.chromium.org/368143002/diff/160001/chrome/browser/ui/webui...
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:110:
controller->DiscardNonCommittedEntries();
SafeBrowsingBlockingPage::IsMainPageLoadBlocked only checks for client side
phishing. I'm not sure if client side malware url should also be checked there.

[meacer, 2014-07-22 21:25:22]

Bernhard, Noé: Ping?

[Bernhard Bauer, 2014-07-23 09:18:35]

LGTM!

[noelutz, 2014-07-24 23:15:15]

lgtm

[meacer, 2014-07-25 20:13:41]

Thanks all!

[meacer, 2014-07-25 20:13:45]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2014-07-25 20:14:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/meacer@chromium.org/368143002/180001

[commit-bot: I haz the power, 2014-07-25 21:10:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/21...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33495)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/38529)

[commit-bot: I haz the power, 2014-07-25 21:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 21:17:04]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[meacer, 2014-07-25 22:34:54]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2014-07-25 22:36:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/meacer@chromium.org/368143002/200001

[meacer, 2014-07-25 22:55:06]

The CQ bit was unchecked by meacer@chromium.org

[meacer, 2014-07-25 22:57:14]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2014-07-25 22:59:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/meacer@chromium.org/368143002/220001

[commit-bot: I haz the power, 2014-07-26 05:02:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-26 18:07:52]

Change committed as 285766

[viettrungluu, 2014-07-26 19:18:11]

On 2014/07/26 18:07:52, I haz the power (commit-bot) wrote:
> Change committed as 285766

Seems to have broken on Linux LSan:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

InterstitialUITest.OpenInterstitial (run #1):
[ RUN      ] InterstitialUITest.OpenInterstitial
...
==12666==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 3088 byte(s) in 2 object(s) allocated from:
    #0 0x4eee7b in operator new(unsigned long)
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x5a69871 in allocate third_party/libc++/trunk/include/memory:1634
    #2 0x5a69871 in allocate third_party/libc++/trunk/include/memory:1439
    #3 0x5a69871 in std::__1::__hash_table\u003Cstd::__1::pair\u003Cint,
linked_ptr\u003Ccontent::RenderFrameHostImpl> >,
__gnu_cxx::__hash_map_hasher\u003Cstd::__1::pair\u003Cint,
linked_ptr\u003Ccontent::RenderFrameHostImpl> >, __gnu_cxx::hash\u003Cint>,
true>, __gnu_cxx::__hash_map_equal\u003Cstd::__1::pair\u003Cint,
linked_ptr\u003Ccontent::RenderFrameHostImpl> >, std::__1::equal_to\u003Cint>,
true>, std::__1::allocator\u003Cstd::__1::pair\u003Cint,
linked_ptr\u003Ccontent::RenderFrameHostImpl> > > >::__rehash(unsigned long)
third_party/libc++/trunk/include/__hash_table:1970
    #4 0x5a5b548 in hash_map third_party/libc++/trunk/include/ext/hash_map:526
    #5 0x5a5b548 in
content::RenderFrameHostManager::RenderFrameHostManager(content::FrameTreeNode*,
content::RenderFrameHostDelegate*, content::RenderViewHostDelegate*,
content::RenderWidgetHostDelegate*, content::RenderFrameHostManager::Delegate*)
content/browser/frame_host/render_frame_host_manager.cc:82
    #6 0x5efe5fd in content::FrameTreeNode::FrameTreeNode(content::FrameTree*,
content::Navigator*, content::RenderFrameHostDelegate*,
content::RenderViewHostDelegate*, content::RenderWidgetHostDelegate*,
content::RenderFrameHostManager::Delegate*, std::__1::basic_string\u003Cchar,
std::__1::char_traits\u003Cchar>, std::__1::allocator\u003Cchar> > const&)
content/browser/frame_host/frame_tree_node.cc:35
    #7 0x5ef6e93 in content::FrameTree::FrameTree(content::Navigator*,
content::RenderFrameHostDelegate*, content::RenderViewHostDelegate*,
content::RenderWidgetHostDelegate*, content::RenderFrameHostManager::Delegate*)
content/browser/frame_host/frame_tree.cc:75
    #8 0x5a28c09 in
content::InterstitialPageImpl::InterstitialPageImpl(content::WebContents*,
content::RenderWidgetHostDelegate*, bool, GURL const&,
content::InterstitialPageDelegate*)
content/browser/frame_host/interstitial_page_impl.cc:154
    #9 0x5a286f6 in content::InterstitialPage::Create(content::WebContents*,
bool, GURL const&, content::InterstitialPageDelegate*)
content/browser/frame_host/interstitial_page_impl.cc:127
    #10 0x278f4c4 in
SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(SafeBrowsingUIManager*,
content::WebContents*,
std::__1::vector\u003CSafeBrowsingUIManager::UnsafeResource,
std::__1::allocator\u003CSafeBrowsingUIManager::UnsafeResource> > const&)
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:313
    #11 0x27a80cf in SafeBrowsingBlockingPageV3
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:1248
    #12 0x27a80cf in
SafeBrowsingBlockingPageFactoryImpl::CreateSafeBrowsingPage(SafeBrowsingUIManager*,
content::WebContents*,
std::__1::vector\u003CSafeBrowsingUIManager::UnsafeResource,
std::__1::allocator\u003CSafeBrowsingUIManager::UnsafeResource> > const&)
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:223
    #13 0x2797188 in
SafeBrowsingBlockingPage::CreateBlockingPage(SafeBrowsingUIManager*,
content::WebContents*, SafeBrowsingUIManager::UnsafeResource const&)
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:885
    #14 0x44bf001 in CreateSafeBrowsingBlockingPage
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:118
    #15 0x44bf001 in (anonymous
namespace)::InterstitialHTMLSource::StartDataRequest(std::__1::basic_string\u003Cchar,
std::__1::char_traits\u003Cchar>, std::__1::allocator\u003Cchar> > const&, int,
int, base::Callback\u003Cvoid (base::RefCountedMemory*)> const&)
chrome/browser/ui/webui/interstitials/interstitial_ui.cc:173
    #16 0x5d2d9bf in
content::URLDataManagerBackend::CallStartRequest(scoped_refptr\u003Ccontent::URLDataSourceImpl>,
std::__1::basic_string\u003Cchar, std::__1::char_traits\u003Cchar>,
std::__1::allocator\u003Cchar> > const&, int, int, int)
content/browser/webui/url_data_manager_backend.cc:657
    #17 0x5d2e1c5 in Run base/bind_internal.h:426
    #18 0x5d2e1c5 in base::internal::InvokeHelper\u003Cfalse, void,
base::internal::RunnableAdapter\u003Cvoid
(*)(scoped_refptr\u003Ccontent::URLDataSourceImpl>,
std::__1::basic_string\u003Cchar, std::__1::char_traits\u003Cchar>,
std::__1::allocator\u003Cchar> > const&, int, int, int)>, void
(content::URLDataSourceImpl*, std::__1::basic_string\u003Cchar,
std::__1::char_traits\u003Cchar>, std::__1::allocator\u003Cchar> > const&, int
const&, int const&, int
const&)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid
(*)(scoped_refptr\u003Ccontent::URLDataSourceImpl>,
std::__1::basic_string\u003Cchar, std::__1::char_traits\u003Cchar>,
std::__1::allocator\u003Cchar> > const&, int, int, int)>,
content::URLDataSourceImpl*, std::__1::basic_string\u003Cchar,
std::__1::char_traits\u003Cchar>, std::__1::allocator\u003Cchar> > const&, int
const&, int const&, int const&) base/bind_internal.h:991
    #19 0x34053ff in Run base/callback.h:401
    #20 0x34053ff in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:458
    #21 0x3406ce0 in DeferOrRunPendingTask base/message_loop/message_loop.cc:470
...

[Will Harris, 2014-07-26 19:18:29]

A revert of this CL has been created in
https://codereview.chromium.org/418293003/ by wfh@chromium.org.

The reason for reverting is: Failing ASAN tests because of leak.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....