chrome/browser/sessions/session_backend.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_backend.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | chrome/browser/spellchecker/spellcheck_host_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_backend.cc

diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc

index 9c214c80b886162b4c155d4fdd9ab6f029df1c90..350ab19bf2f04f4fa194e1650635e1748aec0243 100644

--- a/chrome/browser/sessions/session_backend.cc

+++ b/chrome/browser/sessions/session_backend.cc

@@ -99,8 +99,8 @@ bool SessionFileReader::Read(BaseSessionService::SessionType type,

return false;

ScopedVector<SessionCommand> read_commands;

- SessionCommand* command;

- while ((command = ReadCommand()) && !errored_)

+ for (SessionCommand* command = ReadCommand(); command && !errored_;

+ command = ReadCommand())

read_commands.push_back(command);

if (!errored_)

read_commands.swap(*commands);

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file.cc ('k') | chrome/browser/spellchecker/spellcheck_host_metrics.cc » ('j') | no next file with comments »