chrome/browser/extensions/external_install_error.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/external_install_error.cc

diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc

index a08a40c6e01bb8ebe13549530be4c325b84c34e2..f8671e3cb014411267dad4441a0d98a48c8fc730 100644

--- a/chrome/browser/extensions/external_install_error.cc

+++ b/chrome/browser/extensions/external_install_error.cc

@@ -320,8 +320,8 @@ void ExternalInstallError::OnWebstoreRequestFailure() {

void ExternalInstallError::OnWebstoreResponseParseSuccess(

scoped_ptr<base::DictionaryValue> webstore_data) {

std::string localized_user_count;

- double average_rating;

- int rating_count;

+ double average_rating = 0;

+ int rating_count = 0;

if (!webstore_data->GetString(kUsersKey, &localized_user_count) ||

!webstore_data->GetDouble(kAverageRatingKey, &average_rating) ||

!webstore_data->GetInteger(kRatingCountKey, &rating_count)) {

« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »