chrome/browser/enumerate_modules_model_win.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | chrome/browser/extensions/activity_log/uma_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enumerate_modules_model_win.cc

diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc

index 6c9e11e3e086a20ca17aa1bce61825a97b1f9594..278f7950f7c3a2c653c02a6dc1ed0e06d1bcb70b 100644

--- a/chrome/browser/enumerate_modules_model_win.cc

+++ b/chrome/browser/enumerate_modules_model_win.cc

@@ -780,15 +780,10 @@ base::string16 ModuleEnumerator::GetSubjectNameFromDigitalSignature(

return base::string16();

// Determine the size of the Subject name.

- DWORD subject_name_size = 0;

- if (!(subject_name_size = CertGetNameString(cert_context,

- CERT_NAME_SIMPLE_DISPLAY_TYPE,

- 0,

- NULL,

- 0))) {

+ DWORD subject_name_size = CertGetNameString(

+ cert_context, CERT_NAME_SIMPLE_DISPLAY_TYPE, 0, NULL, NULL, 0);

+ if (!subject_name_size)

return base::string16();

- }

base::string16 subject_name;

subject_name.resize(subject_name_size);