chrome/browser/apps/drive/drive_app_mapping.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_mapping.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/drive/drive_app_mapping.cc

diff --git a/chrome/browser/apps/drive/drive_app_mapping.cc b/chrome/browser/apps/drive/drive_app_mapping.cc

index ae9531014ab83aa6409fa40754cb1c09b85a6a66..c64c06034e000e03003398f76c99c37a78819759 100644

--- a/chrome/browser/apps/drive/drive_app_mapping.cc

+++ b/chrome/browser/apps/drive/drive_app_mapping.cc

@@ -101,7 +101,7 @@ bool DriveAppMapping::IsChromeAppGenerated(

it.Advance()) {

const base::DictionaryValue* info_dict;

std::string value_string;

- bool generated;

+ bool generated = false;

DCHECK(it.value().IsType(base::Value::TYPE_DICTIONARY));

if (it.value().GetAsDictionary(&info_dict) &&

info_dict->GetStringWithoutPathExpansion(kKeyChromeApp,

« no previous file with comments | « no previous file | chrome/browser/component_updater/sw_reporter_installer_win.cc » ('j') | no next file with comments »