chrome/browser/safe_browsing/safe_browsing_store_file.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_store_file.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prerender/prerender_local_predictor.cc ('K') | « chrome/browser/prerender/prerender_local_predictor.cc ('k') | chrome/browser/sessions/session_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_store_file.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_store_file.cc b/chrome/browser/safe_browsing/safe_browsing_store_file.cc

index 01a5dc73395ced463b8b3be37e2c7e44a2d3c32c..e3f615b2cc72322d1293830ca9ef9eb95e3bf6fe 100644

--- a/chrome/browser/safe_browsing/safe_browsing_store_file.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_store_file.cc

@@ -49,7 +49,7 @@ const uint32 kMinShardStride = 1 << 24;

const uint64 kMaxShardStride = 1ULL << 32;

// Maximum SBPrefix value.

-const SBPrefix kMaxSBPrefix = ~0;

+const SBPrefix kMaxSBPrefix = 0xFFFFFFFF;

// Header at the front of the main database file.

struct FileHeaderV8 {

@@ -968,7 +968,7 @@ bool SafeBrowsingStoreFile::DoUpdate(

// needs |in_stride|, while v7 needs to refer to header information.

base::MD5Context in_context;

int version = kInvalidVersion;

- FileHeader header;

+ FileHeader header = {0};

if (!empty_) {

DCHECK(file_.get());