chrome/browser/component_updater/sw_reporter_installer_win.cc - Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 368133005: Fixes for re-enabling more MSVC level 4 warnings: chrome/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_mapping.cc ('k') | chrome/browser/enumerate_modules_model_win.cc » ('j') | chrome/browser/extensions/activity_log/uma_policy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/sw_reporter_installer_win.cc

diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc

index 513362f08f8590aef98f1d390f382a31ab0febfa..75f83c0ea2639ebe1475b2fd7bd3e82dfbe69861 100644

--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc

+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc

@@ -254,7 +254,7 @@ void ExecutePendingSwReporter(ComponentUpdateService* cus, PrefService* prefs) {

// Retrieve the results if the pending request has completed.

base::win::RegKey srt_key(

HKEY_CURRENT_USER, kSoftwareRemovalToolRegistryKey, KEY_READ);

- DWORD exit_code = -1;

+ DWORD exit_code;

if (srt_key.Valid() &&

srt_key.ReadValueDW(kExitCodeRegistryValueName, &exit_code) ==

ERROR_SUCCESS) {