Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 368123002: Remove pointless uses of EventInit (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
blink-reviews, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, vcarbune.chromium, philipj_slow
Project:
blink
Visibility:
Public.

Description

Remove pointless uses of EventInit Setting both bubbles and cancelable to false amounts to the same thing as using the simpler Event::create, so do that intead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M Source/core/html/track/TextTrackList.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/track/TrackListBase.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 5 months ago (2014-07-02 22:58:52 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 5 months ago (2014-07-03 01:07:54 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-03 04:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/368123002/1
6 years, 5 months ago (2014-07-03 04:26:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 04:29:53 UTC) #5
Message was sent while issue was closed.
Change committed as 177446

Powered by Google App Engine
This is Rietveld 408576698