Issue 368043004: Tidied up some divs and css classes + improved usability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 368043004: Tidied up some divs and css classes + improved usability (Closed)

Created:
6 years, 5 months ago by jansson

Modified:
6 years, 5 months ago

Reviewers:
phoglund_chromium

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Tidied up some divs and css classes. Also added some colors to improve the usability of the page highlighting the buttons required to setup a call. Added green color to the buttons used to setup a call. Added red color to the buttons that stop/cancel streams or calls. This is part of a larger refactor effort but doing it in baby steps. BUG=NONE TEST=Manual, no style errors in chrome. NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281721

Patch Set 1 #

Patch Set 2 : More refactor #

Patch Set 3 : More style + refactor #

Patch Set 4 : nit #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -59 lines)			Patch
M	chrome/test/data/webrtc/manual/peerconnection.html	View	1 2	5 chunks	+43 lines, -32 lines	0 comments	Download
M	chrome/test/data/webrtc/manual/peerconnection_manual.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/webrtc/manual/stylesheet.css	View	1 2 3	4 chunks	+48 lines, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/368043004/60001

6 years, 5 months ago (2014-07-08 11:35:08 UTC) #4

Message was sent while issue was closed.

Change committed as 281721

Expand Messages | Collapse Messages