Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 368043002: gen_bench_expectations: use subprocess instead of shell_utils due to buildbot-side name collision (Closed)

Created:
6 years, 5 months ago by borenet
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

gen_bench_expectations: use subprocess instead of shell_utils due to buildbot-side name collision BUG=skia:2714 TBR=rmistry NOTRY=true Committed: https://skia.googlesource.com/skia/+/4621788761e35c3279fbd4efd5b02542eac192b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M tools/gen_bench_expectations_from_codereview.py View 4 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
The CQ bit was checked by borenet@google.com
6 years, 5 months ago (2014-07-02 19:51:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/368043002/1
6 years, 5 months ago (2014-07-02 19:52:16 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 19:52:46 UTC) #3
Message was sent while issue was closed.
Change committed as 4621788761e35c3279fbd4efd5b02542eac192b3

Powered by Google App Engine
This is Rietveld 408576698