Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: Source/web/PopupListBox.cpp

Issue 368023003: Popup open and hide using Alt+KeyDown (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: "Build fix" Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderThemeChromiumMac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PopupListBox.cpp
diff --git a/Source/web/PopupListBox.cpp b/Source/web/PopupListBox.cpp
index 853ad3723cdb8b085fc424fe8776a5d801b78194..c79df0f785939bc001bf1721c6a039f9e9ced4b8 100644
--- a/Source/web/PopupListBox.cpp
+++ b/Source/web/PopupListBox.cpp
@@ -243,6 +243,11 @@ bool PopupListBox::handleKeyEvent(const PlatformKeyboardEvent& event)
break;
}
+ if (event.altKey() && (event.keyIdentifier() == "Down" || event.keyIdentifier() == "Up")) {
+ hidePopup();
+ return true;
+ }
+
if (m_originalIndex != m_selectedIndex) {
// Keyboard events should update the selection immediately (but we don't
// want to fire the onchange event until the popup is closed, to match
« no previous file with comments | « Source/core/rendering/RenderThemeChromiumMac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698