Source/core/html/HTMLSelectElement.h - Issue 368023003: Popup open and hide using Alt+KeyDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 368023003: Popup open and hide using Alt+KeyDown (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: "Build fix" Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 77049422066b0de12d13e1d720a00d4609979270..1d9bf8541f1dd2cd118ca2f11f1b5b7059b5b24b 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -174,7 +174,9 @@ private:

int lastSelectedListIndex() const;

void updateSelectedState(int listIndex, bool multi, bool shift);

void menuListDefaultEventHandler(Event*);

- bool platformHandleKeydownEvent(KeyboardEvent*);

+ void handlePopupOpenKeyboardEvent(Event*);

+ bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*);

+ bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*);

void listBoxDefaultEventHandler(Event*);

void setOptionsChangedOnRenderer();

size_t searchOptionsForValue(const String&, size_t listIndexStart, size_t listIndexEnd) const;

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »