Source/core/rendering/RenderThemeChromiumDefault.h - Issue 368023003: Popup open and hide using Alt+KeyDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderThemeChromiumDefault.h

Issue 368023003: Popup open and hide using Alt+KeyDown (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed mac tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderThemeChromiumDefault.h

diff --git a/Source/core/rendering/RenderThemeChromiumDefault.h b/Source/core/rendering/RenderThemeChromiumDefault.h

index e69546895eae19a83a9895a6f67ad8641b04f44b..a5522396a2433a122570bc19e6599228d3f64496 100644

--- a/Source/core/rendering/RenderThemeChromiumDefault.h

+++ b/Source/core/rendering/RenderThemeChromiumDefault.h

@@ -79,7 +79,9 @@ public:

virtual void adjustInnerSpinButtonStyle(RenderStyle*, Element*) const OVERRIDE;

virtual bool paintInnerSpinButton(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;

- virtual bool popsMenuBySpaceOrReturn() const OVERRIDE FINAL { return true; }

+ virtual bool popsMenuBySpaceKey() const OVERRIDE FINAL { return true; }

+ virtual bool popsMenuByReturnKey() const OVERRIDE FINAL { return true; }

+ virtual bool popsMenuByAltDownUpOrF4Key() const OVERRIDE { return true; }

virtual bool paintProgressBar(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;