Source/web/PopupListBox.cpp - Issue 368023003: Popup open and hide using Alt+KeyDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupListBox.cpp

Issue 368023003: Popup open and hide using Alt+KeyDown (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupListBox.cpp

diff --git a/Source/web/PopupListBox.cpp b/Source/web/PopupListBox.cpp

index 853ad3723cdb8b085fc424fe8776a5d801b78194..269238c8ced5f7a3107cbdb94f511b122a4b5920 100644

--- a/Source/web/PopupListBox.cpp

+++ b/Source/web/PopupListBox.cpp

@@ -243,6 +243,9 @@ bool PopupListBox::handleKeyEvent(const PlatformKeyboardEvent& event)

break;

}

+ if (event.altKey() && event.keyIdentifier() == "Down")

keishi 2014/07/03 07:13:38 We want to support alt+up too.

Habib Virji 2014/07/03 17:24:04 Done.

+ hidePopup();

if (m_originalIndex != m_selectedIndex) {

// Keyboard events should update the selection immediately (but we don't

// want to fire the onchange event until the popup is closed, to match