Popup open and hide using Alt+KeyDown

Source/core/rendering/RenderThemeChromiumMac.h

 /*
  * This file is part of the theme implementation for form controls in WebCore.
  *
  * Copyright (C) 2005 Apple Computer, Inc.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 59 matching lines @@
     virtual int sliderTickOffsetFromTrackCenter() const OVERRIDE;
 
     virtual int popupInternalPaddingLeft(RenderStyle*) const OVERRIDE;
     virtual int popupInternalPaddingRight(RenderStyle*) const OVERRIDE;
     virtual int popupInternalPaddingTop(RenderStyle*) const OVERRIDE;
     virtual int popupInternalPaddingBottom(RenderStyle*) const OVERRIDE;
 
     virtual bool paintCapsLockIndicator(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
 
     virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; }
+    virtual bool popsMenuBySpaceKey() const OVERRIDE FINAL { return true; }
+    virtual bool popsMenuByReturnKey() const OVERRIDE FINAL { return true; }

[keishi, 2014/07/09 03:38:21]

This should be false. On mac the popup should be opened for space but not for
return key.

 
     virtual IntSize meterSizeForBounds(const RenderMeter*, const IntRect&) const OVERRIDE;
     virtual bool paintMeter(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
     virtual bool supportsMeter(ControlPart) const OVERRIDE;
 
     // Returns the repeat interval of the animation for the progress bar.
     virtual double animationRepeatIntervalForProgressBar(RenderProgress*) const OVERRIDE;
     // Returns the duration of the animation for the progress bar.
     virtual double animationDurationForProgressBar(RenderProgress*) const OVERRIDE;
 
@@ skipping 116 matching lines @@
     mutable RetainPtr<NSTextFieldCell> m_textField;
 
     mutable HashMap<int, RGBA32> m_systemColorCache;
 
     RetainPtr<WebCoreRenderThemeNotificationObserver> m_notificationObserver;
 };
 
 } // namespace WebCore
 
 #endif // RenderThemeChromiumMac_h