Popup open and hide using Alt+KeyDown

Source/core/html/HTMLSelectElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
@@ skipping 1166 matching lines @@
             listIndex = nextValidIndex(listIndex, SkipForwards, 3);
         else if (keyIdentifier == "PageUp")
             listIndex = nextValidIndex(listIndex, SkipBackwards, 3);
         else if (keyIdentifier == "Home")
             listIndex = nextValidIndex(-1, SkipForwards, 1);
         else if (keyIdentifier == "End")
             listIndex = nextValidIndex(listItems.size(), SkipBackwards, 1);
         else
             handled = false;
 
+        if (keyIdentifier == "Down" && event->isKeyboardEvent() && toKeyboardEvent(event)->altKey()) {

[keishi, 2014/07/03 07:13:38]

We already open the popup on alt+down/up. It is implemented in
platformHandleKeydownEvent in HTMLSelectElementWin.cpp.
We don't want this shortcut on Mac so this is unnecessary.
We just need to close the popup on alt+down/up.

[Habib Virji, 2014/07/03 08:17:34]

@keishi: What about linux? It does not work for linux, alt+down. Should ifdef
flag be added to make it work in Linux?

[keishi, 2014/07/03 08:38:47]

I think we want this shortcut for Windows and Linux.
We can't share code if we use file names to specify behavior for each
platform(e.g. *Win.cpp and *Linux.cpp)
I think we should use RenderTheme. Please refer to
RenderTheme::shouldOpenPickerWithF4Key

[Habib Virji, 2014/07/03 17:24:04]

Done.

+            focus();
+            if (!renderer() || !renderer()->isMenuList() || isDisabledFormControl())
+                return;
+            saveLastSelection();
+            if (RenderMenuList* menuList = toRenderMenuList(renderer()))
+                menuList->showPopup();
+            event->setDefaultHandled();
+        }
+
         if (handled && static_cast<size_t>(listIndex) < listItems.size())
             selectOption(listToOptionIndex(listIndex), DeselectOtherOptions | DispatchInputAndChangeEvent | UserDriven);
 
         if (handled)
             event->setDefaultHandled();
     }
 
     // Use key press event here since sending simulated mouse events
     // on key down blocks the proper sending of the key press event.
     if (event->type() == EventTypeNames::keypress) {
@@ skipping 461 matching lines @@
 
 void HTMLSelectElement::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_listItems);
 #endif
     HTMLFormControlElementWithState::trace(visitor);
 }
 
 } // namespace