Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 368013002: DevTools: [CSS] fix style ranges updating (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] fix style ranges updating DevTools CSSOM objects (like WebInspector.CSSRule, WebInspector.CSSStyleDeclaration) are addressed by their ranges in source code (aka "source ranges"). Whenever some property gets changed, all the source ranges that lay afterwards in the same stylesheet have to be updated. Unfortunately, there was a typo in this bookkeeping operation. This patch fixes it and covers with a testcase. BUG=390300 R=apavlov, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M LayoutTests/inspector/elements/styles/resources/styles-update-links.css View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles/resources/styles-update-links-2.css View 1 chunk +21 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links-expected.txt View 7 chunks +19 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
Ptal!
6 years, 5 months ago (2014-07-02 14:31:11 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-02 15:01:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/368013002/1
6 years, 5 months ago (2014-07-02 15:02:13 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 15:54:17 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 17:06:03 UTC) #5
Message was sent while issue was closed.
Change committed as 177401

Powered by Google App Engine
This is Rietveld 408576698