Source/core/paint/ThemePainterMac.mm - Issue 368003002: Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ThemePainterMac.mm

Issue 368003002: Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/ThemePainterMac.mm

diff --git a/Source/core/paint/ThemePainterMac.mm b/Source/core/paint/ThemePainterMac.mm

index ffd804b7491d0b7258888eafc43c79d642f66402..95c2f5226ef630de0bae6feffc1332afbe3b0efb 100644

--- a/Source/core/paint/ThemePainterMac.mm

+++ b/Source/core/paint/ThemePainterMac.mm

@@ -184,10 +184,8 @@ bool ThemePainterMac::paintMenuList(LayoutObject* o, const PaintInfo& paintInfo,

NSView *view = m_layoutTheme.documentViewFor(o);

[popupButton drawWithFrame:inflatedRect inView:view];

-#if !BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING

- if (LayoutTheme::isFocused(o) && o->style()->outlineStyleIsAuto())

- [popupButton _web_drawFocusRingWithFrame:inflatedRect inView:view];

-#endif

+ if (!ThemeMac::drawWithFrameDrawsFocusRing() && LayoutTheme::isFocused(o) && o->style()->outlineStyleIsAuto())

+ [popupButton cr_drawFocusRingWithFrame:inflatedRect inView:view];

[popupButton setControlView:nil];

return false;

« no previous file with comments | « Source/core/layout/LayoutThemeMac.mm ('k') | Source/platform/mac/ThemeMac.h » ('j') | no next file with comments »