Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring

Source/platform/mac/ThemeMac.mm

Index: Source/platform/mac/ThemeMac.mm
diff --git a/Source/platform/mac/ThemeMac.mm b/Source/platform/mac/ThemeMac.mm
index 4e702e1b7071e584c8c439a3175eed4eda8ffcbb..07b627e7a0f43045cf7a160de4ae11a7295ba243 100644
--- a/Source/platform/mac/ThemeMac.mm
+++ b/Source/platform/mac/ThemeMac.mm
@@ -168,13 +168,11 @@ static void updateStates(NSCell* cell, ControlStates states)
     if (enabled != oldEnabled)
         [cell setEnabled:enabled];
     
-#if BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING

[Robert Sesek, 2014/07/02 14:45:42]

Why is it safe to remove this?

[keishi, 2014/07/02 15:54:05]

Hmm.
setShowsFirstResponder draws the focus ring on <=10.7
and drawFocusRingMaskWithFrame exists for >=10.7
so on 10.7 two focus rings might be drawn.

Maybe I need to test if drawFocusRingMaskWithFrame exists here too.

[keishi, 2014/07/07 09:16:07]

I confirmed by building using 10.9 SDK and running on 10.7,
setShowsFirstResponder: draws the focus ring and drawFocusRingMaskWithFrame does
nothing. So removing this #if seems to be ok

     // Focused state
     bool oldFocused = [cell showsFirstResponder];
     bool focused = states & FocusControlState;
     if (focused != oldFocused)
         [cell setShowsFirstResponder:focused];
-#endif
 
     // Checked and Indeterminate
     bool oldIndeterminate = [cell state] == NSMixedState;