Refactor color selection out of InlineTextBox::paint.

Refactor color selection out of InlineTextBox::paint.

BUG=388946
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177426

[jbroman, 2014-07-02 17:47:58]

I still think InlineTextBox::paint is too large. This is an LOC-neutral way of
refactoring it; WDYT?

[Stephen Chennney, 2014-07-02 18:04:18]

I'd like it more if there were a way to keep the style data struct around and
invalidate it only when the style actually changes. Have you looked into that?

It's something we talked about at the Silk gathering a couple of weeks back, and
something we'll want moving forward.

[jbroman, 2014-07-02 18:13:27]

On 2014/07/02 18:04:18, Stephen Chenney wrote:
> I'd like it more if there were a way to keep the style data struct around and
> invalidate it only when the style actually changes. Have you looked into that?
> 
> It's something we talked about at the Silk gathering a couple of weeks back,
and
> something we'll want moving forward.

Possible. I'm not sure that this is an expensive part of text recording (it's
probably the paint and/or the glyph positions that are worth caching).

I thought it made it clearer what the inputs and outputs of this step of text
drawing are. If you don't think this is an improvement (or distracts from a
just-over-the-horizon better improvement), I can drop this.

[Stephen Chennney, 2014-07-02 18:35:42]

Let's throw it in. LGTM.

[jbroman, 2014-07-02 21:24:13]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-07-02 21:25:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/367973003/1

[commit-bot: I haz the power, 2014-07-02 21:56:37]

Change committed as 177426