Separate client and server pushed streams limits.

Separate client and server pushed streams limits.
Reject push streams which exceed the limit.

For now, the browser will send RST_STREAM with REFUSED_STREAM status.
This mimics mod_spdy behavior.

BUG=170544, 377538
R=jgraettinger@chromium.org

TEST=SpdySessionTest.PushedStreamShouldNotCountToClientConcurrencyLimit
     SpdySessionTest.RejectPushedStreamExceedingConcurrencyLimit
     SpdySessionTest.IgnoreReservedRemoteStreamsCount

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281698

[baranovich, 2014-07-02 14:41:43]

Push stream limit is still 1000. I think it should be lowered to smth like
100-200

[Johnny, 2014-07-07 19:58:50]

lgtm.

Really nice job on tests, thanks for doing this.

https://codereview.chromium.org/367963003/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://codereview.chromium.org/367963003/diff/1/net/spdy/spdy_session.h#newc...
net/spdy/spdy_session.h:1045: size_t max_concurrent_streams_;  // 0 if no limit
I'm just realizing, it looks like we're not enforcing
|max_concurrent_streams_limit_| anywhere...

https://codereview.chromium.org/367963003/diff/1/net/spdy/spdy_session_unitte...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/367963003/diff/1/net/spdy/spdy_session_unitte...
net/spdy/spdy_session_unittest.cc:4619: // create streams on the client.
Nice!

[baranovich, 2014-07-07 20:16:12]

The CQ bit was checked by baranovich@yandex-team.ru

[commit-bot: I haz the power, 2014-07-07 20:17:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/baranovich@yandex-team.ru/367963003/1

[commit-bot: I haz the power, 2014-07-07 23:54:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-08 00:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:27:09]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[baranovich, 2014-07-08 08:07:57]

The CQ bit was checked by baranovich@yandex-team.ru

[commit-bot: I haz the power, 2014-07-08 08:08:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/baranovich@yandex-team.ru/367963003/1

[commit-bot: I haz the power, 2014-07-08 08:54:05]

Change committed as 281698

[Michael Achenbach, 2014-07-08 10:13:06]

A revert of this CL has been created in
https://codereview.chromium.org/377903002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This breaks asan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%28....

[baranovich, 2014-07-08 20:57:34]

On 2014/07/07 19:58:50, Johnny wrote:
> I'm just realizing, it looks like we're not enforcing
> |max_concurrent_streams_limit_| anywhere...
True. We may either use it when validating server-sent settings instead of
|kMaxConcurrentStreamLimit| or delete it.. I'd prefer delete =)