IDL compiler: constructor attributes

Source/bindings/templates/interface.cpp

Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 2449e4320a484a9f690798a9f910c8eee788ecfc..34912d11253bbc80225c1be562f6cfbe7a5068d6 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -3,12 +3,30 @@
 
 {##############################################################################}
 {% macro attribute_configuration(attribute) %}
-{"{{attribute.name}}", {{attribute.getter_callback_name}}, {{attribute.setter_callback_name}}, {{attribute.getter_callback_name_for_main_world}}, {{attribute.setter_callback_name_for_main_world}}, 0, static_cast<v8::AccessControl>({{attribute.access_control_list | join(' | ')}}), static_cast<v8::PropertyAttribute>({{attribute.property_attributes | join(' | ')}}), 0 /* on instance */}{% endmacro %}
+{"{{attribute.name}}", {{attribute.getter_callback_name}}, {{attribute.setter_callback_name}}, {{attribute.getter_callback_name_for_main_world}}, {{attribute.setter_callback_name_for_main_world}}, {{attribute.wrapper_type_info}}, static_cast<v8::AccessControl>({{attribute.access_control_list | join(' | ')}}), static_cast<v8::PropertyAttribute>({{attribute.property_attributes | join(' | ')}}), 0 /* on instance */}{% endmacro %}
+
+
+{##############################################################################}
+{% block constructor_getter %}
+{% if has_constructor_attributes %}
+static void {{interface_name}}ConstructorGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+    v8::Handle<v8::Value> data = info.Data();
+    ASSERT(data->IsExternal());
+    V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->CreationContext());
+    if (!perContextData)
+        return;
+    v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::unwrap(data)));
+}
+
+{% endif %}
+{% endblock %}
 
 
 {##############################################################################}
 {% block replaceable_attribute_setter_and_callback %}
-{% if has_replaceable_attributes %}
+{% if has_replaceable_attributes or has_constructor_attributes %}
+{# Constructor attributes use ReplaceableAttributeSetter as an interface-level setter #}

[haraken, 2013/10/24 09:13:54]

Thanks, I understood the situation. Both replaceable setters and constructor
attributes are using ReplaceableAttributeSetter because they want to set values
with ForceSet. The point is just that they want to use ForceSet.

Probably a right fix would be to rename ReplaceableAttributeSetter() to
ForceSetAttributeOnThis(). Or you can simply inline info.This()->ForceSet.

(Then you can remove the above comment.)

[Nils Barth (inactive), 2013/10/24 09:41:51]

Will do in quick followup CL (b/c generated code and Perl changes).
Unfortunately it's more complicated for
[CheckSecurity] interface (>.<)
We may still be able to just inline it, but we'll want to
look at it then (when doing interfaces).

 static void {{interface_name}}ReplaceableAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     info.This()->ForceSet(name, jsValue);