media/audio/win/audio_low_latency_input_win.h - Issue 367923004: Turn audio ducking on by default on Windows again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/audio_low_latency_input_win.h

Issue 367923004: Turn audio ducking on by default on Windows again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, update tests, logging and documentation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/win/audio_low_latency_input_win.h

diff --git a/media/audio/win/audio_low_latency_input_win.h b/media/audio/win/audio_low_latency_input_win.h

index a33a582c976a386601e55425d034aba36ee785a8..91fdde159401da7ac7f3aff365e38603c905de90 100644

--- a/media/audio/win/audio_low_latency_input_win.h

+++ b/media/audio/win/audio_low_latency_input_win.h

@@ -157,8 +157,10 @@ class MEDIA_EXPORT WASAPIAudioInputStream

// Length of the audio endpoint buffer.

uint32 endpoint_buffer_size_frames_;

- // A copy of the supplied AudioParameter's |effects|.

- const int effects_;

+ // A copy of the supplied AudioParameter's |effects|. If ducking was

+ // specified (desired device=communications) but we ended up not being

+ // able to open the communications device, this flag will be cleared.

+ int effects_;

// Contains the unique name of the selected endpoint device.

// Note that AudioManagerBase::kDefaultDeviceId represents the default