Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 367923004: Turn audio ducking on by default on Windows again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.cc ('k') | content/renderer/media/media_stream_dispatcher.h » ('j') | content/renderer/media/webrtc_local_audio_renderer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index aede2ffb6668b39f5f03c9bf98bebe96e3adc955..267d1d2fc53567bf5d95c746b6f3710471b4bade 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -336,10 +336,7 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {
}
EXPECT_FALSE(audio_constraints.NeedsAudioProcessing());
#if defined(OS_WIN)
- // TODO(tommi): Turn this back to EXPECT_TRUE on Windows when ducking issues
- // have been resolved.
- // Bugs: crbug/391414, crbug/391247.
- EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));
+ EXPECT_TRUE(audio_constraints.GetProperty(kMediaStreamAudioDucking));
#else
EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));
#endif
« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.cc ('k') | content/renderer/media/media_stream_dispatcher.h » ('j') | content/renderer/media/webrtc_local_audio_renderer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698