Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 367863005: No chrome dependencies in TemplateURLService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index 0974faeba188d7dde19606e3cb1091b59b19448a..7fc1e7d781241ee950e321a66bc39e4a452227c2 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -15,7 +15,6 @@
#include "base/test/mock_time_provider.h"
#include "base/threading/thread.h"
#include "base/time/time.h"
-#include "chrome/browser/history/history_notifications.h"
#include "chrome/browser/history/history_service.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/search_engines/search_host_to_urls_map.h"
@@ -895,9 +894,9 @@ TEST_F(TemplateURLServiceTest, UpdateKeywordSearchTermsForURL) {
"http://icon1", false, "UTF-8;UTF-16", Time(), Time());
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
- history::URLVisitedDetails details;
- details.row = history::URLRow(GURL(data[i].url));
- details.transition = content::PageTransitionFromInt(0);
+ TemplateURLService::URLVisitedDetails details;
Peter Kasting 2014/07/02 20:45:57 Nit: You can use {}-initializer form here and belo
hashimoto 2014/07/03 00:05:07 Done.
+ details.url = GURL(data[i].url);
+ details.is_keyword_transition = false;
model()->UpdateKeywordSearchTermsForURL(details);
EXPECT_EQ(data[i].term, test_util_.GetAndClearSearchTerm());
}
@@ -917,9 +916,9 @@ TEST_F(TemplateURLServiceTest, DontUpdateKeywordSearchForNonReplaceable) {
"http://icon1", false, "UTF-8;UTF-16", Time(), Time());
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
- history::URLVisitedDetails details;
- details.row = history::URLRow(GURL(data[i].url));
- details.transition = content::PageTransitionFromInt(0);
+ TemplateURLService::URLVisitedDetails details;
+ details.url = GURL(data[i].url);
+ details.is_keyword_transition = false;
model()->UpdateKeywordSearchTermsForURL(details);
ASSERT_EQ(base::string16(), test_util_.GetAndClearSearchTerm());
}

Powered by Google App Engine
This is Rietveld 408576698