Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 367863002: Add ScriptForbiddenScopes to style and layout. (Closed)

Created:
6 years, 5 months ago by esprehn
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Add ScriptForbiddenScopes to style and layout. After r177267 script should never run inside updateRenderTree or inside updateLayout except for plugins and the inspector. Lets add some asserts to make sure that it stays that way. BUG=356487 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177455

Patch Set 1 #

Patch Set 2 : Allow inspector script #

Patch Set 3 : Allow inspector script in layout #

Patch Set 4 : Allow inspector script. #

Patch Set 5 : Blank allow inspector scripts. #

Patch Set 6 : Blanket allow inspector scripts. #

Patch Set 7 : Blanket allow inspector scripts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M Source/core/dom/Document.cpp View 2 3 4 5 chunks +6 lines, -5 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 2 3 4 5 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
esprehn
6 years, 5 months ago (2014-07-02 17:38:58 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-02 17:39:55 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-02 17:46:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/367863002/20001
6 years, 5 months ago (2014-07-02 17:46:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-02 18:53:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 19:30:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15134)
6 years, 5 months ago (2014-07-02 19:30:39 UTC) #7
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-02 21:29:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/367863002/40001
6 years, 5 months ago (2014-07-02 21:30:10 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-02 22:40:43 UTC) #10
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-02 23:05:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/367863002/60001
6 years, 5 months ago (2014-07-02 23:05:14 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-03 00:28:54 UTC) #13
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-03 00:53:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/367863002/120001
6 years, 5 months ago (2014-07-03 00:54:53 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-03 01:58:02 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 03:30:15 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28836)
6 years, 5 months ago (2014-07-03 03:30:16 UTC) #18
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-03 03:47:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/367863002/120001
6 years, 5 months ago (2014-07-03 03:48:25 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-03 05:09:27 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 07:15:35 UTC) #22
Message was sent while issue was closed. 
Change committed as 177455

Powered by Google App Engine
This is Rietveld 408576698