Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3906)

Unified Diff: cc/resources/tile_manager.h

Issue 367833003: cc: Start using raster/eviction iterators. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index 5ad80910f8e8aed434edc19e2a04571ce3d62781..b586269cf9ba7404ffe6c58e90856804dfb19943 100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -21,7 +21,6 @@
#include "cc/resources/managed_tile_state.h"
#include "cc/resources/memory_history.h"
#include "cc/resources/picture_pile_impl.h"
-#include "cc/resources/prioritized_tile_set.h"
#include "cc/resources/rasterizer.h"
#include "cc/resources/resource_pool.h"
#include "cc/resources/tile.h"
@@ -124,7 +123,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
~EvictionTileIterator();
EvictionTileIterator& operator++();
- operator bool() const;
+ operator bool();
Tile* operator*();
private:
@@ -155,10 +154,14 @@ class CC_EXPORT TileManager : public RasterizerClient,
TreePriority tree_priority_;
};
+ void Initialize();
+
std::vector<PairedPictureLayerIterator> paired_iterators_;
std::vector<PairedPictureLayerIterator*> iterator_heap_;
TreePriority tree_priority_;
EvictionOrderComparator comparator_;
+ TileManager* tile_manager_;
+ bool initialized_;
DISALLOW_COPY_AND_ASSIGN(EvictionTileIterator);
};
@@ -199,10 +202,8 @@ class CC_EXPORT TileManager : public RasterizerClient,
ManagedTileState::TileVersion& tile_version =
mts.tile_versions[HIGH_QUALITY_RASTER_MODE];
- tile_version.resource_ = resource_pool_->AcquireResource(gfx::Size(1, 1));
-
- bytes_releasable_ += BytesConsumedIfAllocated(tiles[i]);
- ++resources_releasable_;
+ tile_version.resource_ =
+ resource_pool_->AcquireResource(tiles[i]->size());
}
}
@@ -217,12 +218,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
void SetGlobalStateForTesting(
const GlobalStateThatImpactsTilePriority& state) {
- // Soft limit is used for resource pool such that
- // memory returns to soft limit after going over.
- if (state != global_state_) {
- global_state_ = state;
- prioritized_tiles_dirty_ = true;
- }
+ global_state_ = state;
}
void SetRasterizerForTesting(Rasterizer* rasterizer);
@@ -236,13 +232,10 @@ class CC_EXPORT TileManager : public RasterizerClient,
Rasterizer* rasterizer,
RenderingStatsInstrumentation* rendering_stats_instrumentation);
- // Methods called by Tile
- friend class Tile;
- void DidChangeTilePriority(Tile* tile);
-
void CleanUpReleasedTiles();
// Overriden from RefCountedManager<Tile>:
+ friend class Tile;
virtual void Release(Tile* tile) OVERRIDE;
// Overriden from RasterizerClient:
@@ -257,11 +250,30 @@ class CC_EXPORT TileManager : public RasterizerClient,
virtual void ScheduleTasks(
const TileVector& tiles_that_need_to_be_rasterized);
- void AssignGpuMemoryToTiles(PrioritizedTileSet* tiles,
- TileVector* tiles_that_need_to_be_rasterized);
- void GetTilesWithAssignedBins(PrioritizedTileSet* tiles);
+ void AssignGpuMemoryToTiles(TileVector* tiles_that_need_to_be_rasterized);
private:
+ class MemoryUsage {
+ public:
+ MemoryUsage();
+ MemoryUsage(int64 memory_bytes, int resource_count);
+
+ static MemoryUsage FromConfig(const gfx::Size& size, ResourceFormat format);
+ static MemoryUsage FromTile(const Tile* tile);
+
+ MemoryUsage& operator+=(const MemoryUsage& other);
+ MemoryUsage& operator-=(const MemoryUsage& other);
+ MemoryUsage operator-(const MemoryUsage& other);
+
+ bool Exceeds(const MemoryUsage& limit) const;
+
+ int64 memory_bytes() const { return memory_bytes_; }
+
+ private:
+ int64 memory_bytes_;
+ int resource_count_;
+ };
+
void OnImageDecodeTaskCompleted(int layer_id,
SkPixelRef* pixel_ref,
bool was_canceled);
@@ -271,11 +283,6 @@ class CC_EXPORT TileManager : public RasterizerClient,
const PicturePileImpl::Analysis& analysis,
bool was_canceled);
- inline size_t BytesConsumedIfAllocated(const Tile* tile) const {
- return Resource::MemorySizeBytes(tile->size(),
- resource_pool_->resource_format());
- }
-
void FreeResourceForTile(Tile* tile, RasterMode mode);
void FreeResourcesForTile(Tile* tile);
void FreeUnusedResourcesForTile(Tile* tile);
@@ -283,8 +290,16 @@ class CC_EXPORT TileManager : public RasterizerClient,
scoped_refptr<ImageDecodeTask> CreateImageDecodeTask(Tile* tile,
SkPixelRef* pixel_ref);
scoped_refptr<RasterTask> CreateRasterTask(Tile* tile);
- void UpdatePrioritizedTileSetIfNeeded();
+ bool FreeTileResourcesUntilUsageIsWithinLimit(EvictionTileIterator* iterator,
+ const MemoryUsage& limit,
+ MemoryUsage* usage);
+ bool FreeTileResourcesWithLowerPriorityUntilUsageIsWithinLimit(
+ EvictionTileIterator* iterator,
+ const MemoryUsage& limit,
+ const TilePriority& other_priority,
+ MemoryUsage* usage);
+ bool TilePriorityViolatesMemoryPolicy(const TilePriority& priority);
bool IsReadyToActivate() const;
void CheckIfReadyToActivate();
@@ -297,16 +312,8 @@ class CC_EXPORT TileManager : public RasterizerClient,
typedef base::hash_map<Tile::Id, Tile*> TileMap;
TileMap tiles_;
- PrioritizedTileSet prioritized_tiles_;
- bool prioritized_tiles_dirty_;
-
- bool all_tiles_that_need_to_be_rasterized_have_memory_;
- bool all_tiles_required_for_activation_have_memory_;
-
- size_t bytes_releasable_;
- size_t resources_releasable_;
+ bool all_tiles_that_need_to_be_rasterized_are_scheduled_;
- bool ever_exceeded_memory_budget_;
MemoryHistory::Entry memory_stats_from_last_assign_;
RenderingStatsInstrumentation* rendering_stats_instrumentation_;

Powered by Google App Engine
This is Rietveld 408576698