cc: Start using raster/eviction iterators.

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/basictypes.h"
@@ skipping 1205 matching lines @@
   // Mark priorities as dirty and schedule a ManageTiles().
   tile_priorities_dirty_ = true;
   client_->SetNeedsManageTilesOnImplThread();
 }
 
 void LayerTreeHostImpl::DidInitializeVisibleTile() {
   if (client_ && !client_->IsInsideDraw())
     client_->DidInitializeVisibleTileOnImplThread();
 }
 
-const std::vector<PictureLayerImpl*>& LayerTreeHostImpl::GetPictureLayers() {
+const std::vector<PictureLayerImpl*>& LayerTreeHostImpl::GetPictureLayers()
+    const {
   return picture_layers_;
 }
 
 void LayerTreeHostImpl::NotifyReadyToActivate() {
   client_->NotifyReadyToActivate();
 }
 
 void LayerTreeHostImpl::NotifyTileStateChanged(const Tile* tile) {
   TRACE_EVENT0("cc", "LayerTreeHostImpl::NotifyTileStateChanged");
 
   if (active_tree_) {
     LayerImpl* layer_impl =
         active_tree_->FindActiveTreeLayerById(tile->layer_id());
     if (layer_impl)
       layer_impl->NotifyTileStateChanged(tile);
   }
 
   if (pending_tree_) {
     LayerImpl* layer_impl =
         pending_tree_->FindPendingTreeLayerById(tile->layer_id());
     if (layer_impl)
       layer_impl->NotifyTileStateChanged(tile);
   }
 }
 
+RasterTileQueue* LayerTreeHostImpl::GetRasterQueue(TreePriority tree_priority) {
+  // TODO(vmpstr): Investigate if we can skip preparation if nothing changed
+  // (priorities, etc)
+  std::vector<PairedPictureLayer> paired_layers;
+  GetPairedPictureLayers(&paired_layers);
+  raster_queue_.Prepare(paired_layers, tree_priority);

[reveman, 2014/07/09 02:21:09]

I don't think we should use a client function to trigger work that needs to be
done before the queue can be used. I'd rather see us handle that transparently
to the tile manager by preparing the queue or marking it as needing to be
prepared before use as needed.

I don't care how much you optimize this in this patch. You can call Prepare()
before each ManageTiles and whenever a layer is added/removed as far as I care.
I'm just interested in making the interface to the tile manager such that we can
optimize this as much as we like in the future without having to change how we
interact with the tile manager.

[vmpstr, 2014/07/09 18:35:38]

Calling prepare in tile manager seems like a wrong thing to do. I'd like to see
tile manager simply use these queues, without any knowledge of what needs to be
done to them before they are ready to be consumed. Also, preparing requires a
set of layer pairs, and I'd like to avoid both having tile manager get those
pairs and having a client back pointer in the queues.

All in all, when we call prepare can be changed, but I still think tile manager
should not know how to initialize the queues. Would you agree to this solution
as a way that makes tile manager interface simple? I'm willing to work on
figuring out the ideal spot for prepare as a follow-up.

+  return &raster_queue_;
+}
+
+EvictionTileQueue* LayerTreeHostImpl::GetEvictionQueue(
+    TreePriority tree_priority) {
+  // TODO(vmpstr): Investigate if we can skip preparation if nothing changed
+  // (priorities, etc)
+  std::vector<PairedPictureLayer> paired_layers;
+  GetPairedPictureLayers(&paired_layers);
+  eviction_queue_.Prepare(paired_layers, tree_priority);
+  return &eviction_queue_;
+}
+
 void LayerTreeHostImpl::SetMemoryPolicy(const ManagedMemoryPolicy& policy) {
   SetManagedMemoryPolicy(policy, zero_budget_);
 }
 
 void LayerTreeHostImpl::SetTreeActivationCallback(
     const base::Closure& callback) {
   DCHECK(proxy_->IsImplThread());
   DCHECK(settings_.impl_side_painting || callback.is_null());
   tree_activation_callback_ = callback;
 }
@@ skipping 705 matching lines @@
 bool LayerTreeHostImpl::UseOneCopyTextureUpload() const {
   // Sync query support is required by one-copy rasterizer.
   return settings_.use_one_copy && GetRendererCapabilities().using_map_image &&
          resource_provider_->use_sync_query();
 }
 
 void LayerTreeHostImpl::EnforceZeroBudget(bool zero_budget) {
   SetManagedMemoryPolicy(cached_managed_memory_policy_, zero_budget);
 }
 
+void LayerTreeHostImpl::GetPairedPictureLayers(
+    std::vector<PairedPictureLayer>* paired_layers) const {
+  const std::vector<PictureLayerImpl*>& layers = GetPictureLayers();
+
+  paired_layers->clear();
+  // Reserve a maximum possible paired layers.
+  paired_layers->reserve(layers.size());
+
+  for (std::vector<PictureLayerImpl*>::const_iterator it = layers.begin();
+       it != layers.end();
+       ++it) {
+    PictureLayerImpl* layer = *it;
+
+    // TODO(vmpstr): Iterators and should handle this instead. crbug.com/381704
+    if (!layer->HasValidTilePriorities())
+      continue;
+
+    PictureLayerImpl* twin_layer = layer->GetTwinLayer();
+
+    // Ignore the twin layer when tile priorities are invalid.
+    // TODO(vmpstr): Iterators should handle this instead. crbug.com/381704
+    if (twin_layer && !twin_layer->HasValidTilePriorities())
+      twin_layer = NULL;
+
+    PairedPictureLayer paired_layer;
+    WhichTree tree = layer->GetTree();
+
+    // If the current tree is ACTIVE_TREE, then always generate a paired_layer.
+    // If current tree is PENDING_TREE, then only generate a paired_layer if
+    // there is no twin layer.
+    if (tree == ACTIVE_TREE) {
+      DCHECK(!twin_layer || twin_layer->GetTree() == PENDING_TREE);
+      paired_layer.active_layer = layer;
+      paired_layer.pending_layer = twin_layer;
+      paired_layers->push_back(paired_layer);
+    } else if (!twin_layer) {
+      paired_layer.active_layer = NULL;
+      paired_layer.pending_layer = layer;
+      paired_layers->push_back(paired_layer);
+    }
+  }
+}
+
 bool LayerTreeHostImpl::InitializeRenderer(
     scoped_ptr<OutputSurface> output_surface) {
   TRACE_EVENT0("cc", "LayerTreeHostImpl::InitializeRenderer");
 #if DCHECK_IS_ON
   DCHECK(!renderer_ || did_lose_called_);
 #endif
 
   // Since we will create a new resource provider, we cannot continue to use
   // the old resources (i.e. render_surfaces and texture IDs). Clear them
   // before we destroy the old resource provider.
@@ skipping 1165 matching lines @@
 }
 
 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
   std::vector<PictureLayerImpl*>::iterator it =
       std::find(picture_layers_.begin(), picture_layers_.end(), layer);
   DCHECK(it != picture_layers_.end());
   picture_layers_.erase(it);
 }
 
 }  // namespace cc