net/url_request/url_request.cc - Issue 367763004: WIP: Some cronet modifications for the AndroidGSA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 367763004: WIP: Some cronet modifications for the AndroidGSA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Second attempt on UploadChannel Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index 5466be1b58943f2dd311a8faf190581b7e25b4d8..a799c108a566edbb1ffc2a9e4aeb300b4a06b639 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -302,7 +302,8 @@ void URLRequest::AppendChunkToUpload(const char* bytes,

bool is_last_chunk) {

DCHECK(upload_data_stream_);

DCHECK(upload_data_stream_->is_chunked());

- DCHECK_GT(bytes_len, 0);

+ // TODO(miloslav) Check whether we could deal with zero-length chunks

+ // DCHECK_GT(bytes_len, 0);

upload_data_stream_->AppendChunk(bytes, bytes_len, is_last_chunk);

}