Issue 367763004: WIP: Some cronet modifications for the AndroidGSA

Issue 367763004: WIP: Some cronet modifications for the AndroidGSA (Closed)

Created:
6 years, 5 months ago by miloslav

Modified:
4 years, 1 month ago

Reviewers:
marcwilson, mdumitrescu, mef, Allan

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WIP: Some cronet modifications for the AndroidGSA Make some classes public, so the GSA can use them directly, allow asynchronous upload of data, relax the check preventing the uploading of an empty chunk, add a method that returns all response headers. These changes are experimental and not indeded for submission. BUG=

Patch Set 1 #

Patch Set 2 : Cleaned up a bit. #

Patch Set 3 : Second attempt on UploadChannel #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -59 lines)			Patch
M	components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/UrlRequest.java	View	1 2	9 chunks	+124 lines, -54 lines	0 comments	Download
M	components/cronet/android/org_chromium_net_UrlRequest.cc	View		2 chunks	+36 lines, -0 lines	0 comments	Download
M	components/cronet/android/url_request_peer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/cronet/android/url_request_peer.cc	View		1 chunk	+9 lines, -0 lines	2 comments	Download
M	net/url_request/url_request.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mef

Miloslav, thanks a lot! I've adopted it into https://codereview.chromium.org/423163007/. https://codereview.chromium.org/367763004/diff/40001/components/cronet/android/url_request_peer.cc File components/cronet/android/url_request_peer.cc (right): https://codereview.chromium.org/367763004/diff/40001/components/cronet/android/url_request_peer.cc#newcode83 components/cronet/android/url_request_peer.cc:83: ...

6 years, 4 months ago (2014-08-04 21:12:43 UTC) #1

mef

On 2014/08/04 21:12:43, mef wrote: > Miloslav, thanks a lot! I've adopted it into > ...

6 years, 4 months ago (2014-08-14 21:11:08 UTC) #2

miloslav

6 years, 4 months ago (2014-08-18 17:42:25 UTC) #3

Thank you, Misha, for integrating this CL.

https://codereview.chromium.org/367763004/diff/40001/components/cronet/androi...
File components/cronet/android/url_request_peer.cc (right):

https://codereview.chromium.org/367763004/diff/40001/components/cronet/androi...
components/cronet/android/url_request_peer.cc:83: return
url_request_->GetFullRequestHeaders(headers);
On 2014/08/04 21:12:43, mef wrote:
> This returns *request* headers, not *response* headers. Is this what you
expect?

Oh my, I must have been really tired before my vacation. Thanks for noticing :).

Expand Messages | Collapse Messages