Issue 367753003: Enabled chrome_proxy benchmarks on Android as we now have a TryBot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367753003: Enabled chrome_proxy benchmarks on Android as we now have a TryBot. (Closed)

Created:
6 years, 5 months ago by bolian

Modified:
6 years, 5 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enabled chrome_proxy benchmarks on Android as we now have a TryBot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281182

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	tools/perf/benchmarks/chrome_proxy.py	View		5 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bolian

Hello Tony and Dave, Could you look at this CL to enable chrome_proxy tests on ...

6 years, 5 months ago (2014-07-01 18:07:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/367753003/1

6 years, 5 months ago (2014-07-02 22:23:50 UTC) #4

bolian

6 years, 5 months ago (2014-07-09 19:17:33 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/379233003/ by bolian@chromium.org.

The reason for reverting is: chrome_proxy tests need live server access. Android
chromium.perf bots don't have access to live servers and all tests under
tools/perf are now part of chromium.perf. 

It seems chrome_proxy trybot for now can use flag --also-run-disabled-tests to
explicitly run these tests..

Expand Messages | Collapse Messages