Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: test/mjsunit/allocation-site-info.js

Issue 367703002: Test mjsunit/allocation-site-info is flaky without explicit gc() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/allocation-site-info.js
diff --git a/test/mjsunit/allocation-site-info.js b/test/mjsunit/allocation-site-info.js
index 35b60ee266f0ab27cbffff27a51f880d717ecdcc..0545754aa3c2aa8de15d48f8837270feb954af80 100644
--- a/test/mjsunit/allocation-site-info.js
+++ b/test/mjsunit/allocation-site-info.js
@@ -414,6 +414,11 @@ if (support_smi_only_arrays) {
assertKind(elements_kind.fast, obj[1][0]);
})();
+ // Perform a gc because without it the test below can experience an
+ // allocation failure at an inconvenient point. Allocation mementos get
+ // cleared on gc, and they can't deliver elements kind feedback when that
+ // happens.
+ gc();
// Make sure object literals with array fields benefit from the type feedback
// that allocation mementos provide.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698