Issue 367633003: Revert "Linux perf tool support update + refactoring." (r22118).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367633003: Revert "Linux perf tool support update + refactoring." (r22118). (Closed)

Created:
6 years, 5 months ago by Jarin

Modified:
6 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Linux perf tool support update + refactoring." (r22118). Android ninja build still failing. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22119

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -410 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	build/android.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/base/platform/platform.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	src/base/platform/platform-win32.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/log.cc	View	2 chunks	+166 lines, -1 line	0 comments	Download
D	src/perf-jit.h	View	1 chunk	+0 lines, -129 lines	0 comments	Download
D	src/perf-jit.cc	View	1 chunk	+0 lines, -169 lines	0 comments	Download
D	src/third_party/kernel/tools/perf/util/jitdump.h	View	1 chunk	+0 lines, -85 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Jarin

Committed patchset #1 manually as r22119 (tree was closed).

6 years, 5 months ago (2014-07-01 13:12:27 UTC) #1

Yang

6 years, 5 months ago (2014-07-01 13:16:57 UTC) #2

Message was sent while issue was closed.

On 2014/07/01 13:12:27, jarin wrote:
> Committed patchset #1 manually as r22119 (tree was closed).

lgtm.