Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 367593002: Support --alternative-dirs in tools/find_runtime_symbols/prepare_symbol_info.py. (Closed)

Created:
6 years, 5 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 4 months ago
Reviewers:
hajimehoshi
CC:
chromium-reviews, dmikurube+memory_chromium.org
Project:
chromium
Visibility:
Public.

Description

Support --alternative-dirs in tools/find_runtime_symbols/prepare_symbol_info.py. BUG=None TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289256

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebased #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M tools/find_runtime_symbols/prepare_symbol_info.py View 1 2 chunks +27 lines, -9 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi, Trying to flush my piled patches. Could you take a look?
6 years, 4 months ago (2014-08-13 05:03:59 UTC) #1
hajimehoshi
https://codereview.chromium.org/367593002/diff/60001/tools/find_runtime_symbols/prepare_symbol_info.py File tools/find_runtime_symbols/prepare_symbol_info.py (right): https://codereview.chromium.org/367593002/diff/60001/tools/find_runtime_symbols/prepare_symbol_info.py#newcode217 tools/find_runtime_symbols/prepare_symbol_info.py:217: help='Read files in /path/on/host/ instead of ' What does ...
6 years, 4 months ago (2014-08-13 05:13:54 UTC) #2
Dai Mikurube (NOT FULLTIME)
Thanks! https://codereview.chromium.org/367593002/diff/60001/tools/find_runtime_symbols/prepare_symbol_info.py File tools/find_runtime_symbols/prepare_symbol_info.py (right): https://codereview.chromium.org/367593002/diff/60001/tools/find_runtime_symbols/prepare_symbol_info.py#newcode217 tools/find_runtime_symbols/prepare_symbol_info.py:217: help='Read files in /path/on/host/ instead of ' On ...
6 years, 4 months ago (2014-08-13 05:17:03 UTC) #3
hajimehoshi
On 2014/08/13 05:17:03, Dai Mikurube wrote: > Thanks! > > https://codereview.chromium.org/367593002/diff/60001/tools/find_runtime_symbols/prepare_symbol_info.py > File tools/find_runtime_symbols/prepare_symbol_info.py (right): ...
6 years, 4 months ago (2014-08-13 05:19:55 UTC) #4
Dai Mikurube (NOT FULLTIME)
Thanks!
6 years, 4 months ago (2014-08-13 05:20:19 UTC) #5
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 4 months ago (2014-08-13 05:20:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/367593002/60001
6 years, 4 months ago (2014-08-13 05:21:15 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 10:24:31 UTC) #8
Message was sent while issue was closed.
Change committed as 289256

Powered by Google App Engine
This is Rietveld 408576698