Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 367563002: Get sugar out of bower instead of checking it in. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews, Dougle, michaelpg
Project:
blink
Visibility:
Public.

Description

Get sugar out of bower instead of checking it in. This way it's easy to update to new version and we don't have to worry about policies around checking in third party code. Used the full version of the file for now. We can switch to the minified one if we decide the performance matters. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7808 lines) Patch
M Tools/GardeningServer/bower.json View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/GardeningServer/garden-o-matic.html View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/run-unittests.html View 1 chunk +1 line, -1 line 0 comments Download
D Tools/GardeningServer/scripts/third_party/sugar.js View 1 chunk +0 lines, -7804 lines 0 comments Download
M Tools/GardeningServer/ui/ct-sheriff-o-matic.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 5 months ago (2014-07-01 03:11:06 UTC) #1
Dirk Pranke
lgtm
6 years, 5 months ago (2014-07-01 03:19:11 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 5 months ago (2014-07-01 03:23:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/367563002/1
6 years, 5 months ago (2014-07-01 03:24:27 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 03:24:49 UTC) #5
Message was sent while issue was closed.
Change committed as 177268

Powered by Google App Engine
This is Rietveld 408576698