No chrome dependencies in TemplateURLFetcher and TemplateURLParser

chrome/browser/search_engines/template_url_fetcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/callback_helpers.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/search_engines/template_url_fetcher.h"
-#include "chrome/browser/search_engines/template_url_fetcher_callbacks.h"
 #include "chrome/browser/search_engines/template_url_fetcher_factory.h"
 #include "chrome/browser/search_engines/template_url_service_test_util.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/search_engines/template_url.h"
 #include "components/search_engines/template_url_service.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 using base::ASCIIToUTF16;
 
-class TemplateURLFetcherTest;
-
-// Handles callbacks from TemplateURLFetcher.
-class TemplateURLFetcherTestCallbacks : public TemplateURLFetcherCallbacks {
- public:
-  explicit TemplateURLFetcherTestCallbacks(TemplateURLFetcherTest* test)
-      : test_(test) {
-  }
-  virtual ~TemplateURLFetcherTestCallbacks();
-
-  // TemplateURLFetcherCallbacks implementation.
-  virtual void ConfirmAddSearchProvider(TemplateURL* template_url,
-                                        Profile* profile) OVERRIDE;
-
- private:
-  TemplateURLFetcherTest* test_;
-
-  DISALLOW_COPY_AND_ASSIGN(TemplateURLFetcherTestCallbacks);
-};
-
 // Basic set-up for TemplateURLFetcher tests.
 class TemplateURLFetcherTest : public testing::Test {
  public:
   TemplateURLFetcherTest();
 
   virtual void SetUp() OVERRIDE {
     test_util_.SetUp();
     TestingProfile* profile = test_util_.profile();
     ASSERT_TRUE(profile);
     ASSERT_TRUE(TemplateURLFetcherFactory::GetForProfile(profile));
 
     ASSERT_TRUE(profile->GetRequestContext());
     ASSERT_TRUE(test_server_.InitializeAndWaitUntilReady());
   }
 
   virtual void TearDown() OVERRIDE {
     ASSERT_TRUE(test_server_.ShutdownAndWaitUntilComplete());
     test_util_.TearDown();
   }
 
-  // Called by ~TemplateURLFetcherTestCallbacks.
-  void DestroyedCallback(TemplateURLFetcherTestCallbacks* callbacks);
+  // Called when the callback is destroyed.
+  void DestroyedCallback();
 
   // TemplateURLFetcherCallbacks implementation.  (Although not derived from
   // this class, this method handles those calls for the test.)
-  void ConfirmAddSearchProvider(TemplateURL* template_url, Profile* profile);
+  void ConfirmAddSearchProvider(
+      base::ScopedClosureRunner* callback_destruction_notifier,
+      scoped_ptr<TemplateURL> template_url);
 
  protected:
   // Schedules the download of the url.
   void StartDownload(const base::string16& keyword,
                      const std::string& osdd_file_name,
                      TemplateURLFetcher::ProviderType provider_type,
                      bool check_that_file_exists);
 
   // Waits for any downloads to finish.
   void WaitForDownloadToFinish();
@@ skipping 11 matching lines @@
   int add_provider_called_;
 
   // Is the code in WaitForDownloadToFinish in a message loop waiting for a
   // callback to finish?
   bool waiting_for_download_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TemplateURLFetcherTest);
 };
 
-TemplateURLFetcherTestCallbacks::~TemplateURLFetcherTestCallbacks() {
-  test_->DestroyedCallback(this);
-}
-
-void TemplateURLFetcherTestCallbacks::ConfirmAddSearchProvider(
-    TemplateURL* template_url,
-    Profile* profile) {
-  test_->ConfirmAddSearchProvider(template_url, profile);
-}
-
 TemplateURLFetcherTest::TemplateURLFetcherTest()
     : callbacks_destroyed_(0),
       add_provider_called_(0),
       waiting_for_download_(false) {
   base::FilePath src_dir;
   CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &src_dir));
   test_server_.ServeFilesFromDirectory(
       src_dir.AppendASCII("chrome/test/data"));
 }
 
-void TemplateURLFetcherTest::DestroyedCallback(
-    TemplateURLFetcherTestCallbacks* callbacks) {
+void TemplateURLFetcherTest::DestroyedCallback() {
   callbacks_destroyed_++;
   if (waiting_for_download_)
     base::MessageLoop::current()->Quit();
 }
 
 void TemplateURLFetcherTest::ConfirmAddSearchProvider(
-    TemplateURL* template_url,
-    Profile* profile) {
-  last_callback_template_url_.reset(template_url);
+    base::ScopedClosureRunner* callback_destruction_notifier,
+    scoped_ptr<TemplateURL> template_url) {
+  last_callback_template_url_ = template_url.Pass();
   add_provider_called_++;
 }
 
 void TemplateURLFetcherTest::StartDownload(
     const base::string16& keyword,
     const std::string& osdd_file_name,
     TemplateURLFetcher::ProviderType provider_type,
     bool check_that_file_exists) {
 
   if (check_that_file_exists) {
     base::FilePath osdd_full_path;
     ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &osdd_full_path));
     osdd_full_path = osdd_full_path.AppendASCII(osdd_file_name);
     ASSERT_TRUE(base::PathExists(osdd_full_path));
     ASSERT_FALSE(base::DirectoryExists(osdd_full_path));
   }
 
   // Start the fetch.
   GURL osdd_url = test_server_.GetURL("/" + osdd_file_name);
   GURL favicon_url;
+  base::ScopedClosureRunner* callback_destruction_notifier =
+      new base::ScopedClosureRunner(
+          base::Bind(&TemplateURLFetcherTest::DestroyedCallback,
+                     base::Unretained(this)));
+
   TemplateURLFetcherFactory::GetForProfile(
       test_util_.profile())->ScheduleDownload(
           keyword, osdd_url, favicon_url, NULL,
-          new TemplateURLFetcherTestCallbacks(this), provider_type);
+          base::Bind(&TemplateURLFetcherTest::ConfirmAddSearchProvider,
+                     base::Unretained(this),
+                     base::Owned(callback_destruction_notifier)),
+          provider_type);
 }
 
 void TemplateURLFetcherTest::WaitForDownloadToFinish() {
   ASSERT_FALSE(waiting_for_download_);
   waiting_for_download_ = true;
   base::MessageLoop::current()->Run();
   waiting_for_download_ = false;
 }
 
 TEST_F(TemplateURLFetcherTest, BasicAutodetectedTest) {
@@ skipping 156 matching lines @@
   StartDownload(keyword, osdd_file_name,
                 TemplateURLFetcher::EXPLICIT_PROVIDER, true);
   ASSERT_EQ(0, add_provider_called_);
   ASSERT_EQ(1, callbacks_destroyed_);
 
   WaitForDownloadToFinish();
   ASSERT_EQ(1, add_provider_called_);
   ASSERT_EQ(2, callbacks_destroyed_);
   ASSERT_TRUE(last_callback_template_url_.get());
 }